Failed to execute function parameter 1 is not of type response

kwhitley / itty-router

A little router.

MIT License

1.75k stars 78 forks source link

If you respond with html not using the router then you don't get the error. I still get html in the preview, but the stackstraces are really annoyining in terminal. Everything works but with stack traces in terminal. I believe it will still show underlying errors like reference errors and stuff but you have to scroll more.

import { Router } from 'itty-router'
import {html, HTMLResponse} from '@worker-tools/html'
import {layout} from "./views/layout.js"
import paypal from './paypal.js'
const router = Router()
router.get('/', function handleRequest(event) {
  const page = html`
    abc  `
  return new HTMLResponse (layout(page));
})
router.all('/paypal/*', paypal.fetch)

addEventListener('fetch', event =>
event.respondWith(new HTMLResponse (layout(html`abc  `)))
  // event.respondWith(router.handle(event.request))
)

layoutjs

import {html, HTMLResponse} from '@worker-tools/html'

export function layout (content, title = "Source Domains") {
  return html`
<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="utf-8">
    <title>${title}</title>
  </head>
  <body>${content}</body>
</html>
`;}

export default function render (content, title = "Source Domains"){
  return new HTMLResponse(layout(content, title))
}

A few things here:

route handlers don't get passed the "event", but rather a "Request". You're not using the event inside the route handler anyway, but that's something important to note.
a direct fetch call is unlikely to be appropriate for a route handler either, as it needs to either return nothing (e.g. middleware), or a response (assuming you are returning the results of router.handle directly in event.respondWith(router.handle(event.request))
without seeing the request you're feeding through the router, I can't tell what is actually happening int he router. If you fail to catch the route for instance, and didn't provide a catch-all route at the end (e.g. router.all('*', () => missing('Ooops!'))), then your worker code will crash, having not provided a response to the original route.
itty-router doesn't care at all about the content that is returned... returning HTML is no problem at all, as it never even looks at the content, so my suspicion is you're simply failing to catch your route.

Closing this as not an issue until you're able to provide more details about the routes being fed through this, and other missing parts like what paypal.fetch entails.

kwhitley / itty-router

Failed to execute function parameter 1 is not of type response #63