Change where/findWhere to deeply compare objects (fixes issue #39)

kwhitley / treeize

Converts row data (in JSON/associative array format) to tree structure based on column naming conventions.

MIT License

189 stars 24 forks source link

Change where/findWhere to deeply compare objects (fixes issue #39) #40

Open rhinoceraptor opened 7 years ago

rhinoceraptor commented 7 years ago

I didn't see any contributor guidelines, but I'm happy to make any changes, write docs, etc.

rhinoceraptor commented 7 years ago

I'm closing this, it was fixed here.

Thanks @kwhitley !

kwhitley commented 7 years ago

Aww man, I didn't see this (somehow)... I'm going to re-open and evaluate. You appear to have more thorough tests and didn't roll back to the lodash dependency like I did.

👍

rhinoceraptor commented 7 years ago

I'm a little nervous about the recursion, it might be good to put in a fixed upper bound? I haven't looked at lodash to see how they implement object equality.