search

kwi / i18n_routing

I18n routing module for Rails 2.3.x and Rails 3. Translate your routes with ease !
MIT License
228 stars 48 forks source link

Added locale recognition #23

Closed kalifs closed 13 years ago

kalifs commented 13 years ago

I added locale recognition for rails 3, it uses constraints, it works ok in our applications, only problem is with custom resources or other routes defination constraints. i'm not sure my patch accept or reject incoming request right, and its not working with constraints procs. but everything else works fine.

kwi commented 13 years ago

Thanks Arturs ! Damn ! have 3 patches to check now, why is there so much activities on the gem currently ! I will take time to do it soon, thanks a lot

2011/9/9 Arturs Meisters < reply@reply.github.com>

I added locale recognition for rails 3, it uses constraints, it works ok in our applications, only problem is with custom resources or other routes defination constraints. i'm not sure my patch accept or reject incoming request right, and its not working with constraints procs. but everything else works fine.

You can merge this Pull Request by running:

git pull https://github.com/ithouse/i18n_routing master

Or you can view, comment on it, or merge it online at:

https://github.com/kwi/i18n_routing/pull/23

-- Commit Summary --

  • route recognation added
  • conflict resolved
  • readme updated
  • readme updated
  • readme updated
  • readme updated
  • include given hash constraints in constraint match

-- File Changes --

M README.rdoc (17) M lib/i18n_routing_rails3.rb (61)

-- Patch Links --

https://github.com/kwi/i18n_routing/pull/23.patch https://github.com/kwi/i18n_routing/pull/23.diff

Reply to this email directly or view it on GitHub: https://github.com/kwi/i18n_routing/pull/23

kwi commented 13 years ago

Hey Arturs, so I had a quick look and I'm not sure the purpose of I18n_routing is to handle/recognize the current locale of the app, this is very app specific, so I will not merge it right now :/ Thanks !