search

kwi / i18n_routing

I18n routing module for Rails 2.3.x and Rails 3. Translate your routes with ease !
MIT License
228 stars 48 forks source link

Broken with Rails 3.2 #33

Closed maximeg closed 12 years ago

maximeg commented 12 years ago

This (excellent) gem is broken with the freshly released Rails 3.2.

Due to require 'rack/mount' in lib/i18n_routing_rails3.rb. Indeed, Rails 3.2 use Journey for the routing.

AaronH commented 12 years ago

Just discovered this myself. I'm going to try to fork it for a quick fix, but considering it is an all new routing engine, I fear this is going to be a pretty big deal.

Update: Yeah, this is a pretty big deal. I don't have the bandwidth for this at the moment, but it's going to take some serious tweaking to get this to work as currently designed.

kwi commented 12 years ago

Hello Maxime,

Yes, I know :/ Unfortunately, I have currently no time to fix and to maintain the gem anymore :/

2012/1/20 Maxime Garcia < reply@reply.github.com

This (excellent) gem is broken with the freshly released Rails 3.2.

Due to require 'rack/mount' in lib/i18n_routing_rails3.rb. Indeed, Rails 3.2 use Journey for the routing.

Reply to this email directly or view it on GitHub: https://github.com/kwi/i18n_routing/issues/33

francesc commented 12 years ago

Hey,

Just a former user of i18n_routing and translate_routes. Seeing both of them unmaintained I forked translate_routes into (https://github.com/francesc/rails-translate-routes) and made minor improvements. Still not working in 3.2 because of the Journey engine change but planning to rewrite it in order to support it in the following weeks. If somebody is interested in helping just let me know!

Thanks kwi for the work you've done.

kwi commented 12 years ago

Hey, good news :) Good luck with that!

2012/1/23 Francesc Pla < reply@reply.github.com

Hey,

Just a former user of i18n_routing and translate_routes. Seeing both of them unmaintained I forked translate_routes into ( https://github.com/francesc/rails-translate-routes) and made minor improvements. Still not working in 3.2 because of the Journey engine change but planning to rewrite it in order to support it in the following weeks. If somebody is interested in helping just let me know!

Thanks kwi for the work you've done.

Reply to this email directly or view it on GitHub: https://github.com/kwi/i18n_routing/issues/33#issuecomment-3611102

jdcrutchley commented 12 years ago

I put in a pull request to make this work with 3.2.

@kwi: If you don't want to upkeep anymore, let me know and maybe we can work out a transfer. I'm happy to try to keep up.

francesc commented 12 years ago

You got it first working. Congrats! :)

ncri commented 12 years ago

@jdcrutchley: great! we got rails translate-routes-working as well with 3.2: https://github.com/francesc/rails-translate-routes/issues/7#issuecomment-3708388

kwi commented 12 years ago

@jdcrutchley Awesome! You are now admin on the project, feel free to merge and change whatever you need! (I need your email to make you owner on rubygems.org too)

Thanks!

jdcrutchley commented 12 years ago

E-mail is jdcrutchley@spiffworks.com. Thanks! On Jan 29, 2012 5:31 PM, "Guillaume" < reply@reply.github.com> wrote:

@jdcrutchley Awesome! You are now admin on the project, feel free to merge and change whatever you need! (I need your email to make you owner on rubygems.org too)

Thanks!

Reply to this email directly or view it on GitHub: https://github.com/kwi/i18n_routing/issues/33#issuecomment-3712439

kwi commented 12 years ago

Done!

2012/1/29 Jamie Crutchley < reply@reply.github.com

E-mail is jdcrutchley@spiffworks.com. Thanks! On Jan 29, 2012 5:31 PM, "Guillaume" < reply@reply.github.com> wrote:

@jdcrutchley Awesome! You are now admin on the project, feel free to merge and change whatever you need! (I need your email to make you owner on rubygems.org too)

Thanks!

Reply to this email directly or view it on GitHub: https://github.com/kwi/i18n_routing/issues/33#issuecomment-3712439

Reply to this email directly or view it on GitHub: https://github.com/kwi/i18n_routing/issues/33#issuecomment-3713264