Closed slackermorris closed 9 months ago
Here we go. Lol.
I should really upgrade to Node 18.
Big upgrades.
Perhaps something else to be concerned about.
I also updated sst
:
Eeeep. Think we are going to have some difficulties here.
It is probably a good idea to figure out the relevance of that vite
plugin.
If I comment everything out on the page, then things start working again.
I returned the StarMenu
component and stripped it back to nothing and I still noticed the same errors. So, seems like something to do with React.
Notice that the Header
component does not cause the same error. The only difference is that it does not import React.
OK. It has something to do with the client:load
tag we pass the component.
This might be of some help.
I have been tasked with setting up a code space so that I can replicate the issue.
I am going to try to nuke the project before trying to set up a code space.
I have noticed this error in the console.
This might come in handy later on when I am attempting to solve for the above: https://github.com/Accudio/async-alpine/issues/27#issuecomment-1435703790
This offers a really handy explanation: https://stackoverflow.com/questions/69300341/typeerror-failed-to-fetch-dynamically-imported-module-on-vue-vite-vanilla-set
Network trace for my current broken branch feature/upgrade-astro-and-introduce-view-transitions
.
master
network trace.
I did a git bisect
.
Something has gone waaaaay skew whiff.
The only thing that seems culprit is this. Green being what I added to this, the broken commit.
OK. Let's try again and see if we can upgrade the astro sst
integration.
astro sst
integration. This is what I am using to upgrade sst
to v.2.35.0
.
Cool. Running that resulted in this:
Alright. We are back to square one.
I am going to try bumping a version higher. I wonder if 2.35.0
actually supports Astro 3.0
?
This feels interesting: https://www.joshmedeski.com/posts/upgrading-to-astro-v3/
Lol. 2.36.1
works.
I am going to try replicate the issue using StackBlitz. I found an Astro template here.
Wait. What the fuck. 2.35.0
is now working on my local.
I can't explain this at all.
OK scratch that I did a npm i
and it has bonked again.
Here is my Stackblitz.
I can't seem to replicate my issue. Everything seems to be working fine.
I do know that this plugin is my issue.
I nuked the node_modules
and the package-lock
. I'll see what that does.
I can't get a replication in that StackBlitz sandbox. Maybe I try for a new project on my machine?
Looks like I got it to work.
![Uploading Screen Shot 2023-11-17 at 9.12.32 AM.png…]()
Screenshot for above.
🔦 THIS WORKS
"sst": "2.35.0"
, "astro-sst": "2.35.0"
/ "@astrojs/react": "^2.2.1"
"astro": "^3.5.5"
.{
"dependencies": {
"@astrojs/react": "^2.2.1",
"astro": "^3.5.5"
},
"devDependencies": {
"astro-sst": "2.35.0",
"aws-cdk-lib": "2.101.1",
"constructs": "10.2.69",
"sst": "2.35.0"
}
}
"sst": "2.36.1"
, "astro-sst": "2.36.1"
/ "@astrojs/react": "^3.0.4"
"astro": "^3.5.5"
.This is curious because @astro/react 3.0.4
does not play nice with sst 2.35.0
.
{
"dependencies": {
"@astrojs/react": "^3.0.4",
"astro": "^3.5.5"
},
"devDependencies": {
"astro-sst": "2.36.1",
"aws-cdk-lib": "2.101.1",
"constructs": "10.2.69",
"sst": "2.36.1"
}
}
DOES IT WORK IF I BUMP THE REACT INTEGRATION?
WHAT HAPPENS IF I BUMP THE SST INTEGRATION?
WHAT HAPPENS IF ASTRO IS BUMPED LOWER THAN 3.5.5?
🧧 THIS DOES NOT WORK
{
"name": "bad-reviews-make-good-movies",
"type": "module",
"version": "0.0.1",
"engines": {
"node": ">=18.14.1"
},
"scripts": {
},
"dependencies": {
"@astrojs/react": "^3.0.4",
"astro": "^3.4.3",
},
"devDependencies": {
"astro-sst": "2.35.0",
"aws-cdk-lib": "2.101.1",
"constructs": "10.2.69",
"sst": "2.35.0",
}
}
"sst": "2.35.0"
, "astro-sst": "2.35.0"
/ "@astrojs/react": "^3.0.4"
"astro": "^3.5.5"
.It's the @astrojs/react
integration which is causing the issue.
{
"dependencies": {
"@astrojs/react": "^3.0.4", <----- THIS IS THE NOTICEABLE DIFFERENCE
"astro": "^3.5.5"
},
"devDependencies": {
"astro-sst": "2.35.0",
"aws-cdk-lib": "2.101.1",
"constructs": "10.2.69",
"sst": "2.35.0"
}
}
Basically prove that it is the @astrojs/react
integration. Astro are the maintainers but the conflict is with sst
so perhaps I should raise the issue to both of them.
Cool. Solution is to bump everything to its most recent version.
This PR took care of the @astrojs/react
astro-sst
issues.