search

kwikteam / klustakwik2

Fast software for high-dimensional cluster analysis using the masked EM algorithm for Gaussians mixtures
BSD 3-Clause "New" or "Revised" License
27 stars 13 forks source link

Compile Cython in setup.py instead of pyximport #42

Closed rossant closed 9 years ago

rossant commented 9 years ago

This might simplify packaging on the various platforms, compared to pyximport (@mstimberg any opinion on this?)

mstimberg commented 9 years ago

I think it is preferable to do this in setup.py, this will also allow you to easily build binary packages (e.g. for conda). It's normally really straightforward: http://docs.cython.org/src/reference/compilation.html#compiling-with-distutils

The only thing that makes our setup script in Brian 2 a bit complicated is that we allow installation without Cython from the source package, i.e. we support both building from a .pyx file (when building from the source directly from github) and building fom the .cpp file (when building from the source package). In retrospect, I think it'd be just fine to simply build-depend on Cython...

thesamovar commented 9 years ago

I agree this would be better: I only didn't do it yet because I'm lazy.