SetupStringParameters sets with specifier

kwilcz / Antario

Clean base/cheat made for CS:GO.

MIT License

133 stars 34 forks source link

SetupStringParameters sets with specifier #82

Closed noche-x closed 5 years ago

noche-x commented 5 years ago

First off im new to using github and I'm sorry if I'm doing this wrong.

Before: csgo_2019-03-10_22-54-02

After: NVIDIA_Share_2019-03-10_22-58-23

kwilcz commented 5 years ago

Thanks for that pr, just 1 quick thing - please replace 8space tab with 4space for consistency :)

noche-x commented 5 years ago

I think it's a bug where there are 8 spacings. It's normal on my source but not on github. No problem :)

kwilcz commented 5 years ago

MSVC shows tab always as 4 spaces, no matter how big the spacing is. Change settings to these, and then reformat.

kwilcz commented 5 years ago

After some testing of this:

Yours:
Old one:

I don't know why you have an issue with the "1" showing up at the end. With multiple tests - it doesnt show up on my side.

the code you've added just removes 1 character after the found %. Perhaps it needs some further debugging.

noche-x commented 5 years ago

As i posted on my screenshot for example when i int testintegervalue = 123; Utils::Log("test %i", testintegervalue); it outputs like test 123i so when i remove the char after % it will fix it for me

noche-x commented 5 years ago

But as i examine it for the second time its not like printf. Silly me % just works fine.

kwilcz commented 5 years ago

It doesnt work 1:1 like printf, no need for type specifiers. Closing as issue got resolved.