Fix --use-system-libraries not working with Rake install

kwilczynski / ruby-magic

Simple interface to libmagic for Ruby Programming Language

Apache License 2.0

27 stars 8 forks source link

Fix --use-system-libraries not working with Rake install #19

Closed stanhu closed 3 years ago

stanhu commented 3 years ago

Previously the libmagic tarball and patches were required to be present in the current directory for rake compile -- --use-system-libraries to work. To fix this, we now dynamically add these dependencies when building the gem.

stanhu commented 3 years ago

@kwilczynski I think the build failures here are unrelated, so I'm just going to merge. 😄

stanhu commented 3 years ago

I guess I can't merge without approval. 😄

kwilczynski commented 3 years ago

Hi @stanhu,

I guess I can't merge without approval. 😄

Sorry about that! Although, I am not sure why - the only thing I enabled (or re-enabled, rather) yesterday was requirement to sign commits, as per:

Screenshot 2021-04-20 at 08 14 04

Does it still pose problems?

Krzysztof

flavorjones commented 3 years ago

Apologies for not sending a PR for this earlier! Thanks for taking care of it!

kwilczynski commented 3 years ago

Hi @flavorjones,

Apologies for not sending a PR for this earlier! Thanks for taking care of it!

Thank YOU for doing all the work on enabling us to ship native Ruby Gems and to better the users experience!

Krzysztof

stanhu commented 3 years ago

Yes, thank you @flavorjones for helping us with this project! I cribbed more Nokogiri work into this project. 😄