search

kwilczynski / ruby-magic

Simple interface to libmagic for Ruby Programming Language
Apache License 2.0
27 stars 8 forks source link

Check for pkg-config when building static libraries #26

Closed stanhu closed 2 years ago

stanhu commented 2 years ago

Previously we would fail with an unclear +: no implicit conversion of nil into String error when the pkg-config did not run successfully. We now raise an exception to help explain why.

stanhu commented 2 years ago

@kwilczynski Thanks. For some reason, I'm still having trouble pushing this gem to Rubygems:

$ gem push -v ruby-magic-0.5.1.gem
GET https://rubygems.org/latest_specs.4.8.gz
304 Not Modified
Pushing gem to https://rubygems.org...
POST https://rubygems.org/api/v1/gems
401 Unauthorized
You have enabled multi-factor authentication. Please enter OTP code.
Code:   xxxxxx
POST https://rubygems.org/api/v1/gems
422 Unprocessable Entity
RubyGems.org cannot process this gem.
Please try rebuilding it and installing it locally to make sure it's valid.
Error:
not enough data

I don't have any trouble with any other gem. Would you mind pushing 0.5.1 for me?

kwilczynski commented 2 years ago

Hi @stanhu,

Oh no! I am sorry about this. I will push new version.

I wonder if we should reach out to the Rubygems folks to ask what the issue might be, perhaps there is something they could see on their end, something in the logs, or such. Having said that, I am actually not sure how do you approach them to get proper support, I need to have a look.

Krzysztof

kwilczynski commented 2 years ago

Hi @stanhu,

Pushed the 0.5.1.

Thank you for cutting the release!

Krzysztof