search

kwilczynski / ruby-magic

Simple interface to libmagic for Ruby Programming Language
Apache License 2.0
27 stars 8 forks source link

Remove workaround for linux build per RCD #33

Closed larskanis closed 2 years ago

larskanis commented 2 years ago

It is no longer necessary with rake-compiler-dock-1.2.1. It is fixed in https://github.com/rake-compiler/rake-compiler-dock/issues/65

kwilczynski commented 2 years ago

Hi @larskanis,

This looks great! Thank you so much for taking care of this, I really appreciate it.

I also think that @flavorjones would be happy to get the new release of rake-compiler-dock for Nokogiri. 😄

Krzysztof

kwilczynski commented 2 years ago

Hi @stanhu,

Before we merge, I need to quickly make sure that the Gem would build correctly on a few systems when building locally -- Red Hat, CentOS, Debian, Ubuntu... with the Ruby they ship, and under rbenv and RVM.

Krzysztof

stanhu commented 2 years ago

@kwilczynski I'm testing Debian bullseye here: https://gitlab.com/stanhu/ruby-magic/-/jobs/2219990176

stanhu commented 2 years ago

I think the failure is unrelated:

/usr/local/rvm/rubies/ruby-3.1.0/lib/ruby/3.1.0/fileutils.rb:243:in `mkdir': File exists @ dir_s_mkdir - /builds/stanhu/ruby-magic/ext/magic/share (Errno::EEXIST)
    from /usr/local/rvm/rubies/ruby-3.1.0/lib/ruby/3.1.0/fileutils.rb:243:in `fu_mkdir'
    from /usr/local/rvm/rubies/ruby-3.1.0/lib/ruby/3.1.0/fileutils.rb:186:in `block in mkdir'
    from /usr/local/rvm/rubies/ruby-3.1.0/lib/ruby/3.1.0/fileutils.rb:185:in `each'
    from /usr/local/rvm/rubies/ruby-3.1.0/lib/ruby/3.1.0/fileutils.rb:185:in `mkdir'
    from ../../../../ext/magic/extconf.rb:323:in `<main>'

It seems we may be missing a rake clobber in between platforms? Trying again in https://gitlab.com/stanhu/ruby-magic/-/jobs/2220023361.

kwilczynski commented 2 years ago

Hi @larskanis and @stanhu,

Sorry for late reply!

Everything works on multiple versions of Ubuntu, Debian and CentOS, etc. Tested with Ruby that ships with the distribution, plus installation under RVM and rbenv. No issues.

Thank you so much @larskanis! Much appreciated!

Krzysztof

kwilczynski commented 2 years ago

Hi @larskanis,

Sorry to bother you, but would you mind signing your commit? Let me know if you don't have GPG set up, so that I can deal with this on our side.

Krzysztof

larskanis commented 2 years ago

Sorry to bother you, but would you mind signing your commit? Let me know if you don't have GPG set up, so that I can deal with this on our side.

I updated the commit with a signature of my PGP key.

kwilczynski commented 2 years ago

Hi @larskanis,

Sorry to bother you, but would you mind signing your commit? Let me know if you don't have GPG set up, so that I can deal with this on our side.

I updated the commit with a signature of my PGP key.

You rock! Thank you so much!

Krzysztof