search

kwiliarty / glyphworks

MIT License
0 stars 0 forks source link

Add copy button to glyph pages #92

Closed andyzito closed 1 year ago

kwiliarty commented 1 year ago

Oh, I just noticed that this is actually still a draft. Sorry if I jumped in too soon. Anyway, maybe the feedback is still helpful?

andyzito commented 1 year ago

Not at all, thank you for catching those things. The cleanup bits should all be resolved in the latest commit. Working on tests...

andyzito commented 1 year ago

@kwiliarty Is this what you had in mind for tests? Not 100% sure the expect...toBeCalledTimes lines are correct, but the tests pass.

kwiliarty commented 1 year ago

@andyzito : This is still marked as a draft. Was there something else you wanted to do on it, or do you think it's ready to go?

andyzito commented 1 year ago

@kwiliarty Ready!

kwiliarty commented 1 year ago

Live! https://glyph.works/glyphs/right-tail-d