This is some initial feedback. I am sure there are more things, but this is what immediately jumps out.
LMK if any questions.
Feature
[x] Is there a specific reason the column modifier primary has a different color than the other column modifiers (e.g. notnull, max, unique, etc. If there is no reason, I suggest all modifiers have the same color.
[x] Add syntax highlighting for index values. E.g.
[ ] IMO, we should remove autocomplete for SQL keywords. It leads to a lot of suggestions when typing actions/procedures. @brennanjl @charithabandi thoughts?
Bugs / UX Feedback
[x] If i define a database, delete the database, then start typing da... I no longer get the database autocomplete. I only get the tables, actions, and procedures. It should revert to recommending database.
[x] Keywords do not highlight until after the syntax is complete, however, they should highlight immediately if defined in a location where the keyword is acceptable. For example, if i type database mydb, there is no highlighting. But if i type database mydb;, highlighting applies to both database and mydb. This also applies to tables, actions, and procedures.
[ ] Within the table block, I receive autocompletes for procedures and actions. It looks like this is caused because, upon first defintion, the parser does not realize we are within a valid table block. Example:
[ ] If I define a table, then delete the table and try to define again, i lose the table autocomple. E.g. start here:
then delete and start a new table:
[x] The red on table in return table is a bit jarring and looks like an error. Maybe a more subtle blue (like the same color used in the table definition) would be better? E.g.
[x] If I type a $ and then select the autocomplete param, it inserts an extra $. Start here:
leads to this:
This is some initial feedback. I am sure there are more things, but this is what immediately jumps out.
LMK if any questions.
Feature
primary
has a different color than the other column modifiers (e.g.notnull
,max
,unique
, etc. If there is no reason, I suggest all modifiers have the same color.Bugs / UX Feedback
da...
I no longer get thedatabase
autocomplete. I only get thetables
,actions
, andprocedures
. It should revert to recommendingdatabase
.database mydb
, there is no highlighting. But if i typedatabase mydb;
, highlighting applies to bothdatabase
andmydb
. This also applies to tables, actions, and procedures.return table
is a bit jarring and looks like an error. Maybe a more subtle blue (like the same color used in the table definition) would be better? E.g.$
and then select the autocomplete param, it inserts an extra $. Start here: