search

kwilteam / kwil-db

Kwil DB, the database for web3
https://www.kwil.com/
Other
36 stars 12 forks source link

adds array_agg #1028

Closed brennanjl closed 2 months ago

brennanjl commented 2 months ago

This PR adds the array_agg function.

Sorry for the 11th hour addition, I had promised this to someone and totally forgot. Thankfully it is very easy to add this type of stuff.

brennanjl commented 2 months ago

LGTM. I haven't thought through the various combinations of start/distinct/order by, but I guess it's as is should be in PGFormat. Then don't mix an match?

Yeah, users can use distinct, but nothing else. It's not necessarily hard to allow custom ordering, but since this is an 11th hour addition I'd rather not since it's not that big of a deal to not have IMO