search

kwilteam / kwil-db

Kwil DB, the database for web3
https://www.kwil.com/
Other
36 stars 12 forks source link

update our pg docker image to 16.4, and use in test #1041

Closed jchappelow closed 1 month ago

jchappelow commented 1 month ago

This updates our customized postgres Docker image in build/package/docker/postgres.dockerfile to extend the official postgres:16.4 image, bumped from 16.2. I have been using 16.4 since it's release it's release about 2 months ago, and I think it's a good idea to update our official image before 0.9 release.

This PR also starts using our postgres image in all of our tests. It was used for the pg-enabled unit tests, but not in acceptance or integration tests. We should be testing our image more consistently. What this means is not of the special startup flags or the injected pginit.sql script need to be part of the docker compose files since they are already part of our extended postgres image.

NOTE: I have already pushed kwildb/postgres:16.4-1 to Docker Hub, but I have not yet tagged this as latest, which still points to 16.2-1. If all is well with this PR and subsequent CI runs, we should update the latest tag.

jchappelow commented 1 month ago

Will wait to approve once you publish a latest Kwil Postgres image

latest tag is pushed now.

and update all references of kwildb/postgres:16.4-1 to kwildb/postgres:latest

I'm a little uncertain about this step. We previously pinned tests to a specific version, which seems best to me. This will stabilize the tests on, say, a release branch even if we later push a new latest. The other thing was that latest might force both CI and our workstation machines to keep asking docker hub for the current latest, whereas if it's a version it will just go with what it has.

brennanjl commented 1 month ago

Ok good point. lgtm then