Closed brennanjl closed 11 months ago
That sounds about right. This should be effectively a dedicated kwild server start
with the enhancements and simplifications you named.
We do need to define our own structs even for the comet bft stuff, although that has been convenient up until now.
If I can knock out my current tasks, I'd like to like to address some of this re-architecture, and probably using https://github.com/alexflint/go-arg (I've not used before but it looks excellent in my view) for a purely struct-based scheme for accomplishing all the precendence and in a single location. Note that this package does support subcommands and is highly configurable so I believe we could also use it in kwil-admin where we want multiple (sub)commands.
Ah @charithabandi is on this. That sounds right. I would like to suggest possibly going with go-arg in lieu of viper though.
Ah @charithabandi is on this. That sounds right. I would like to suggest possibly going with go-arg in lieu of viper though.
We can divide these up as needed; I believe Charitha said she would get this during the meeting Thursday, which is why I assigned it to her.
As discussed in https://github.com/kwilteam/kwil-db/issues/247,
kwild
should be its own stand-alone binary. This should include:config.toml.sample
in the root directory.The binary should support the following flags:
--quickstart
, which will auto-generate private key and genesis if it does not exist--root_dir
, which specifies the root directory (AFAIK this would not exist within the config file, since this specifies where the config is).ENG-198