search

kwin-scripts / kwin-tiling

Tiling script for kwin
GNU General Public License v2.0
1.1k stars 68 forks source link

Fix window gaps being incorrectly applied when a window is being resized #190

Closed nwwdles closed 4 years ago

nwwdles commented 4 years ago

Hello!

When I'm resizing a window, (window) gaps around it disappear. It only affects the window being resized, while all other windows around it are positioned correctly.

That is, when the right mouse button is pressed, the window occupies the whole tile (see screenshot), ignoring the window_gap setting. And when the button is released, the gaps finally get applied and the window shrinks. So, for example, if you attempt to expand a window by 1px and your window gaps are 16px, the window actually shrinks 15px after you release the button. The bug also affects Resize Active Window To The X hotkeys. This is most noticeable when you are using large window gaps.

This PR attempts to fix it, please feel free to point out any mistakes.

Screenshot_20200104_021352

laloch commented 4 years ago

Merged in #207. @cupnoodles14, I gave you the credit. Thanks for contributing!