search

kwin-scripts / kwin-tiling

Tiling script for kwin
GNU General Public License v2.0
1.1k stars 68 forks source link

Option to keep floating windows on top #218

Closed addy419 closed 4 years ago

addy419 commented 4 years ago

when tiling is enabled by default and you change current window to floating, disable keep below and re-enable it again when tiled. this setting can be optional.

faho commented 4 years ago

https://github.com/kwin-scripts/kwin-tiling/blob/master/contents/code/tilelist.js#L335

This already happens.

addy419 commented 4 years ago

My tiled windows overlap floating windows. This happens only happens when I toggle floating, not when I ignore it or when tile isn't set by default. I am using the latest version from master. I rechecked the window and keep below others is still enabled when floating

addy419 commented 4 years ago

@faho to reproduce this, open multiple windows, then use TILING toggle floating shortcut to float a particular window, then click on one of the tiled windows behind this window. It'll go below it.

faho commented 4 years ago

Yeah, that's what KWin does. AFAIK there's no way around that. We reset keepBelow/keepAbove, that's all we can do.

addy419 commented 4 years ago

@faho It does work when I add the window to ignore list? Why doesn't KWin interefere then?

addy419 commented 4 years ago

I rechecked the window and keep below others is still enabled when I toggle floating

faho commented 4 years ago

Yeah, something's borken here. Lemme check.

faho commented 4 years ago

Yeah, for some reason we resized the client after its tile was removed, which re-set keepBelow.

addy419 commented 4 years ago

I was trying to narrow this down, but couldn't find it. Thanks for the fix, works great now👍