search

kwin-scripts / kwin-tiling

Tiling script for kwin
GNU General Public License v2.0
1.1k stars 68 forks source link

Match floaters against both resClass and resName #222

Closed laloch closed 4 years ago

laloch commented 4 years ago

WM_CLASS consists of two strings - resourceClass and resourceName. This makes us match our floaters list against both of them instead of only resourceClass.

Closes #221

faho commented 4 years ago

Is there a danger of clients being accidentally matched by name?

Is there e.g. a filemanager that changes its name to the directory it's in, so e.g. it goes into a directory called "steam" and is then matched by the user's "steam" rule?

Or am I overthinking this?

fabianski7 commented 4 years ago

Is there e.g. a filemanager that changes its name to the directory it's in

dolphin has an option for this, but it is disabled by default

laloch commented 4 years ago

WM_NAME is not the same as WM_CLASS.resName.

laloch commented 4 years ago

We could also match both, e.g. "resourceName:resourceClass", to be completely sure.

faho commented 4 years ago

You know what? Let's just try it.

I can't think of an immediate problem case, so let's see if anything happens in practice.