search

kwin-scripts / kwin-tiling

Tiling script for kwin
GNU General Public License v2.0
1.1k stars 68 forks source link

Adding GridLayout #223

Closed GabrielScheibler closed 3 years ago

GabrielScheibler commented 4 years ago

Adding GridLayout supporting master and slave tiles Adding GridLayout tab to the config ui Adding a description to the layouts field in the config ui

laloch commented 3 years ago

OK, I did, however, already found an issue. In the below Grid layout configuration I can't move the active tile to the right using Meta+Shift+L shortcut anymore.

Screenshot_20201106_194828

v3ss0n commented 3 years ago

This is the layout i am waiting for , @faho can you take a look?

GabrielScheibler commented 3 years ago

@laloch

Could you please add an option (possibly defaulting to off) to have a master tile in the Grid layout too?

In the grid layout you can control master count with the same shortcuts as in the half layout, and the master count is set to zero by default. I think that should solve the problem, unless you are talking about the way new columns are added to the grid?

In the below grid layout configuration I can't move the active tile to the right using Meta+Shift+L shortcut anymore.

I actually cannot reproduce this issue, works just fine for me. Can you narrow down under which circumstances it breaks? And does it only break on the grid layout?

GabrielScheibler commented 3 years ago

In the below Grid layout configuration I can't move the active tile to the right using Meta+Shift+L shortcut anymore.

@laloch , the issue you mentioned should be solved with the latest commits

laloch commented 3 years ago

In the below Grid layout configuration I can't move the active tile to the right using Meta+Shift+L shortcut anymore.

@laloch , the issue you mentioned should be solved with the latest commits

Yep, I can confirm that it works now, thanks!

laloch commented 3 years ago

Could you please add an option (possibly defaulting to off) to have a master tile in the Grid layout too?

In the grid layout you can control master count with the same shortcuts as in the half layout, and the master count is set to zero by default. I think that should solve the problem, unless you are talking about the way new columns are added to the grid?

Yes, I know. I can, however, imagine that users of ultrawide (21:9) and super ultrawide (32:9) monitors would prefer to have always at least one master tile per desktop and it's super annoying to add the master tile manually each time.

GabrielScheibler commented 3 years ago

Yes, I know. I can, however, imagine that users of ultrawide (21:9) and super ultrawide (32:9) monitors would prefer to have always at least one master tile per desktop and it's super annoying to add the master tile manually each time.

Ah okay, I see. I added the option to specify the default master count in the latest commit.

laloch commented 3 years ago

Thanks @GabrielScheibler, this looks great to me! @faho, could you please take a look?

faho commented 3 years ago

Nice, merged, thanks!