kwin-scripts / kwin-tiling

Tiling script for kwin
GNU General Public License v2.0
1.1k stars 68 forks source link

setting horizontal/vertical layout for i3layout not working #226

Open andaag opened 3 years ago

andaag commented 3 years ago

I've started playing with i3 layout and I could not at all understand how it was meant to mimic i3. It essentially just stacked windows left to right, never splitting horizontally.

This was confusing enough I started looking at the code, and put a printf in https://github.com/kwin-scripts/kwin-tiling/blob/master/contents/code/i3layout.js#L118 . Turns out my setup always layouts with normal mode.

Then I put some more printf on these lines : https://github.com/kwin-scripts/kwin-tiling/blob/master/contents/code/tilingmanager.js#L568 and according to them the layout.layout.state is set, but then not picked up on when actually layouting the window.

I'm running kwin 5.18.5 on ubuntu 20.04.1. Any ideas on how to debug this or what might be going wrong here?

faho commented 3 years ago

All I can say is this works for me.

Are you using multiple monitors? That code only sets the state for the current monitor.

andaag commented 3 years ago

Nope, only the single monitor.

Any extra print's I can put in the code somewhere logical to debug this one? I'm mostly on https://github.com/lingtjien/Grid-Tiling-Kwin these days since I prefer the way it places windows, but I'm happy to help debug this regardless.

v3ss0n commented 3 years ago

It shows in OSD that I3layout had switched but i see no difference with blade layout. I changed horziontal and vertical using shortcut but nothing changed, i opened 6 windows but it is all tiled vertically ,in a column Here are the list of layouts that is working :

cinelerra-gg commented 3 years ago

I have exactly the same problem. The i3layout is only shown in vertical view, but not in horizontal view. I've tried everything, but I can't find a solution.

sortedcord commented 3 years ago

Me too. Also, what does the normal mode in i3 mean? I set a keybind to it and opened 6 windows and nothing happened. It was tiling windows vertically and wasnt wrapping them horizontally. However, after fiddling around a lot, I figured out that it does tile horizontally.... kinda...

These are my keybinds-

Screenshot_20210109_115156

and after trying random combinations I landed up with this layout- Screenshot_20210109_120141

Steps to recreate-

Open Browser >> Meta + H >> Open Terminal >> [With Focus on Browser] Meta+V >> Open Terminal

I don't know if this is how it was meant to be, but it definitely can be improved further on. It is very confusing

ankitp4t3l commented 3 years ago

Ditto

Also, what does the normal mode in i3 mean?