search

kwin-scripts / kwin-tiling

Tiling script for kwin
GNU General Public License v2.0
1.1k stars 68 forks source link

What keyboard shortcuts are supported and how to change them? #71

Closed piotr-dobrogost closed 7 years ago

piotr-dobrogost commented 7 years ago

I can't find information on what keyboard shortcuts are supported. Does tiling register global shortcuts so that one could edit them using "Global Shortcuts" system settings module?

faho commented 7 years ago

Does tiling register global shortcuts so that one could edit them using "Global Shortcuts" system settings module?

Yes.

The script offers the following shortcuts:

I actually wanted these to all start with "TILING", but I changed the wrong argument, and changing it now wouldn't remove the old ones.

Also, none of these names are localized because I don't know how.

piotr-dobrogost commented 7 years ago

I actually wanted these to all start with "TILING", but I changed the wrong argument, and changing it now wouldn't remove the old ones.

Even better if all these shortcuts could have been placed under separate entry in Global Keyboard Shorctucts.

Meanwhile I wouldn't bother with leftover ones and would suggest to prefix them with TILING as you originally intended.

jluttine commented 7 years ago

Where can I find these shortcut definitions? I looked under System Settings -> Shortcuts and there "Standard Shortcuts", "Global Shortcuts", "Web Shortcuts" and "Custom Shortcuts" but couldn't find those listed shortcuts. I'm using KDE Plasma version 5.8.5 under NixOS.

piotr-dobrogost commented 7 years ago

Wow, NixOS!

Under Global Shortcuts choose KWin component.

jluttine commented 7 years ago

Nope, none of those appears to be there. Just lots of other standard KWin shortcuts. I both searched and manually read the list. Any ideas what could be wrong? I hope I have the correct KWin script installed: Tiling Extension version 1.7.0 by Fabian Hombord.

faho commented 7 years ago

Tiling Extension version 1.7.0 by Fabian Hombord.

@jluttine: That's an old version that (I think) had the shortcuts disabled. You'll need to upgrade.

Also my last name is spelled with a "g" - like the creatures from Star Trek. I am the Homborg, resistance is futile! 😄

jluttine commented 7 years ago

So the version available from System Settings -> Window Management -> KWin Scripts -> Get New Script -> kwin-tiling-plasma5 is old? I expected that to be the correct way to install the latest stable release as it's the only channel offered by KDE. Anyway, I now uninstalled that and followed the instructions on readme using git clone etc. However, I believe KWin is still using the old version or nothing. Also, the version 1.7.0 is still listed in KWin Scripts.. I'm really confused. I don't find any sign that the script installed with readme instructions is actually installed. How can I confirm that and also check the version? FYI, I'm new to KDE.

EDIT: If it matters, I get the following messages when installing

$ plasmapkg2 --type kwinscript -i .
pluginname:  "kwin-script-tiling"
org.kde.plasma: Could not register package as service (this is not necessarily fatal): "kwin-script-kwin-script-tiling.desktop"
Successfully installed /....foobar...../kwin-tiling

EDIT2: A few more outputs if useful:

Seems to find some information:

$ plasmapkg2 -s kwin-script-tiling
Showing info for package: kwin-script-tiling
      Name : Tiling Extension
   Comment : 
    Plugin : kwin-script-tiling
    Author : Fabian Homborg
      Path : /home/jluttine/.local/share/kwin/scripts/kwin-script-tiling/

However, doesn't list as an installed package (not sure if it should):

$ plasmapkg2 -l
No metadata file in the package, expected it at: "/home/jluttine/.local/share/kwin/scripts/"
No metadata file in the package, expected it at: "/home/jluttine/.local/share/kwin/scripts/"
Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() for "/home/jluttine/.local/share/kwin/scripts" instead of kservice_desktop_to_json() in your CMake code.
Constructing a KPluginInfo object from old style JSON. Please use kcoreaddons_desktop_to_json() for "/home/jluttine/.local/share/kwin/scripts" instead of kservice_desktop_to_json() in your CMake code.
Listing service types: Plasma/Applet, Plasma/Containment
........
jluttine commented 7 years ago

Also, how do I uninstall the script? Readme contains only installation instructions..

EDIT: And sorry for getting off-topic. Perhaps I should open a separate issue or ask using some other forum?

eddhannay commented 7 years ago

@jluttine It could be that you have an older version of kwin - https://github.com/faho/kwin-tiling/blob/master/contents/code/tilingmanager.js#L178, suggests that 5.8.3 is required for these shortcuts to appear in the settings panel.

piotr-dobrogost commented 7 years ago

@eddhannay From https://github.com/faho/kwin-tiling/issues/71#issuecomment-269766261

I'm using KDE Plasma version 5.8.5 under NixOS.

eddhannay commented 7 years ago

My mistake - New to kde, I found this issue trying to solve the same issue, discovered I was running 5.8.2 and hadn't realised that the kwin version was tied to the Plasma version.

piotr-dobrogost commented 7 years ago

No problem. Welcome to KDE!

faho commented 7 years ago

However, I believe KWin is still using the old version or nothing

Do the shortcuts still not work? Did you restart kwin after you updated?

Also, how do I uninstall the script? Readme contains only installation instructions..

Actually you should be able to plasmapkg2 -r kwin-script-tiling, but it seems to currently be borked for me for kwinscripts (though it's also possible some of the fiddling I did during dev caused this).

If it doesn't work for you either, you can disable it in systemsettings and remove the directory from ~/.local/share/kwin/scripts. I think then kbuildsycoca5 should pick up that it's been removed.

Also, the version 1.7.0 is still listed in KWin Scripts

I haven't bumped the version yet. I should probably do that, and make a new release.

And sorry for getting off-topic. Perhaps I should open a separate issue or ask using some other forum?

If you have any further questions, please open a separate issue.

haadr commented 7 years ago

Just thought I'd chime in.

I'm running plasmashell 5.8.4 (debian testing) and I have the same problem of it not displaying the shortcuts under Global Shortcuts/Kwin. Also, removing the plugin via plasmapkg2 -r kwin-script-tiling doesn't work (as expected?) and removing the directory and logging out and in again doesn't help either, it's still displayed in under KWin Scripts.

Otherwise it seems to be active as expected when activated, but that doesn't help when I can't see the shortcuts to use it :D

faho commented 7 years ago

The question has been answered.

winterdeaf commented 5 years ago

Sorry for necrobumping this, but I had the same problem (no shortcuts showing in Global Keyboard Shortcuts -> KWin) on NixOS, and I managed to find a workaround.

I first executed the commands:

mkdir -p ~/.local/share/kservices5
ln -s ~/.local/share/kwin/scripts/kwin-script-tiling/metadata.desktop ~/.local/share/kservices5/kwin-script-tiling.desktop

as suggested here. I then updated the tiling extension (plasmapkg2 --type kwinscript -u .), disabled it in Kwin Scripts, and re-enabled it. The shortcuts appeared!

I don't know how many users might have been affected by this, it could be worth mentioning in the troubleshooting section of the README.

florianjacob commented 5 years ago

@m-scr NixOS 18.09 as well, kwin 5.13.4, recently installed kwin-tiling via

git clone https://github.com/faho/kwin-tiling.git
cd kwin-tiling/
plasmapkg2 --type kwinscript -i .

and for me, the shortcuts appeared like expected. Did you install via Get New Script or via plasmapkg2 and the git repo?

winterdeaf commented 5 years ago

@florianjacob I installed via plasmapkg2, but I was on the nixos-unstable channel. It appears to work on the old stable 18.09, I haven't tested 19.03 yet.