search

kwin / cppcheclipse

Eclipse plugin integrating cppcheck with Eclipse CDT
Apache License 2.0
48 stars 13 forks source link

Problum Occurred during parsing CPPcheck output version 1.84 #90

Closed Hansvdsteen closed 5 years ago

Hansvdsteen commented 6 years ago

The following output syntax is introduced at CPPcheck version 1.84 and will generate a 'Problem Ocurred' pop-up with the reason 'Resource '/project/nofile' does not exist.'

CPPcheck Console output: nofile;0;information;missingIncludeSystem;Cppcheck cannot find all the include files (use --check-config for details)

The first 2 tokens (nofile and 0) where in previous versions of cppcheclk defined as empty strings. It would be nice to support this, so the combination 'nofile' on line '0' is special and is used for general information instead of an error pointing to a real file.

truhlikfredy commented 6 years ago

You are saying that you were using cppcheck 1.83 before and that had no problems? And the problem is introduced only with 1.84?

Hansvdsteen commented 6 years ago

That's what it looks like yes. Ik could not find anything about it in the release notes of 1.84, buy it seems something had been changed here.

Op 12 sep. 2018 13:12 schreef Anton Krug notifications@github.com:

You are saying that you were using cppcheck 1.83 before and that had no problems? And the problem is introduced only with 1.84?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/kwin/cppcheclipse/issues/90#issuecomment-420610799, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Anlc4QDpNJm_pSHqTCH6WPNKvsq-of7Sks5uaOw0gaJpZM4VZlAs.

Margulis commented 6 years ago

I have the same problem. Cppcheck runs in Eclipse by "cppcheclipse" plugin. Default settings. Command: /usr/bin/cppcheck --template={file};{line};{severity};{id};{message} --enable=all --verbose --platform=unix64 --std=c++11 --file-list=-

Console output: nofile;0;information;missingInclude;Cppcheck cannot find all the include files. Cppcheck can check the code without the include files found. But the results will probably be more accurate if all the include files are found. Please check your project's include directories and add all of them as include directories for Cppcheck. To see what files Cppcheck cannot find use --check-config.

Hansvdsteen commented 5 years ago

Wondering if someone is looking at/fixing this problem, please do!

Margulis commented 5 years ago

The problem is also reproducing in CPPcheck version 1.85.

kwin commented 5 years ago

This is open source. I am happy to accept high quality PRs.

kwin commented 5 years ago

This should be fixed by https://github.com/kwin/cppcheclipse/commit/0da3574eec3a399e38ed4d09f63330bbb42d4a41.

pexus commented 5 years ago

When will this fix be available on the Eclipse Market Place - Is there a binary available somewhere? Thanks

ghost commented 5 years ago

Still getting the error which is mentioned above. Cppcheck 1.8.5 and 1.8.6 used.

snip

snip 2

I have installed cppcheclipse remotely and via Eclipse Marketplace, but both versions show the errors given above.

Hansvdsteen commented 5 years ago

Thats because this issue is solved for release 1.1.1, but is not released yet.

AntonKrug commented 5 years ago

I'm usually building the artifact myself. But having official build would help as there was none in good while

Hansvdsteen commented 5 years ago

@kwin it would be nice to make a release 1.1.1 now.. i have 'a lot' of questions about when this issue will be solved.. And actually for a lot of people it is solved when it is in an official release.

AntonKrug commented 5 years ago

I concur, I have to make my own custom build as my PR got accepted to solve one issue I needed to solve, but it's not in the release because latest release 2-3 years old

Hansvdsteen commented 5 years ago

If i can help you with something.. please let me know

^Hans van der Steen

From: Anton Krug notifications@github.com Sent: Tuesday, 2 July 2019 11:13 To: kwin/cppcheclipse cppcheclipse@noreply.github.com Cc: Hans van der Steen hans.vandersteen@locamation.com; Author author@noreply.github.com Subject: Re: [kwin/cppcheclipse] Problum Occurred during parsing CPPcheck output version 1.84 (#90)

I concur, I have to make my own custom build as my PR got accepted to solve one issue I needed to solve, but it's not in the release because latest release 2-3 years old

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/kwin/cppcheclipse/issues/90?email_source=notifications&email_token=AJ4VZYK2V7VSTPKRXSYY5B3P5MLZ3A5CNFSM4FLGKAWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZAT2HQ#issuecomment-507591966, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJ4VZYI2QREZIDVSHUHIFDDP5MLZ3ANCNFSM4FLGKAWA.

AntonKrug commented 5 years ago

Thanks, for the offer, I would like to just see a release build to recheck what things work and do not work. On my build i'm using a PR for different issue and for this one with cppcheck 1.84 I just stayed version behind.

Hansvdsteen commented 5 years ago

If you say a release build.. you mean 1.1.1? Is the pull-request on your build needed for 1.1.1? which PR do you actually mean?

^Hans van der Steen

From: Anton Krug notifications@github.com Sent: Tuesday, 2 July 2019 11:18 To: kwin/cppcheclipse cppcheclipse@noreply.github.com Cc: Hans van der Steen hans.vandersteen@locamation.com; Author author@noreply.github.com Subject: Re: [kwin/cppcheclipse] Problum Occurred during parsing CPPcheck output version 1.84 (#90)

Thanks, for the offer, I would like to just see a release build to recheck what things work and do not work. On my build i'm using a PR for different issue and for this one with cppcheck 1.84 I just stayed version behind.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/kwin/cppcheclipse/issues/90?email_source=notifications&email_token=AJ4VZYI6AGIYB6CCT4J6YCLP5MMNNA5CNFSM4FLGKAWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZAUKAQ#issuecomment-507593986, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJ4VZYLGTXVN75XVJAQMZODP5MMNNANCNFSM4FLGKAWA.

AntonKrug commented 5 years ago

Yes the 1.1.1.

Is the pull-request on your build needed for 1.1.1?

I do not get this question, can you rephrase it?

It's this PR: https://github.com/kwin/cppcheclipse/pull/82

Hansvdsteen commented 5 years ago

@AntonKrug i mean is your PR something which solves something which may block making a release 1.1.1? My PR (#92) is already taken over.. so actually ready to be released in 1.1.1. @kwin So what is taken so long?

AntonKrug commented 5 years ago

No it shouldn't block release of the 1.1.1 It looks like the same situation with your PR

AntonKrug commented 5 years ago

@Hansvdsteen I would guess @kwin is very busy, this repo is not his only project and people have life etc...

ehoeks commented 5 years ago

If someone can build a BETA for the 1.1.1. I would be glad to test it. Got some big gnu-mcu-eclipse projects that stress the cppcheclipse thoroughly.

kwin commented 5 years ago

I am hoping to get around doing a release this weekend.

AntonKrug commented 5 years ago

@ehoeks if you have maven installed, you can try to build it yourself. Something like this could work:

mvn clean package

keyuracharya commented 5 years ago

hi, can anyone please update 1.1.1 to the eclipse market place? it seems that marketplace is still having 1.1.0 Unfortunately all those who use the plugin will not have necessary software installed to build at their end.

Hansvdsteen commented 5 years ago

@keyuracharya i think 1.1.1 is still not released yet. @kwin do you know when it will be?

Hansvdsteen commented 4 years ago

@kwin is there already a plan of making the 1.1.1 release in the near future?

kwin commented 4 years ago

@Hansvdsteen Are you interested in getting commit rights of this project and try the release yourself? I currently don't really find time for this...

Hansvdsteen commented 4 years ago

@kwin i am not familiar with the release process of eclipse plugins, but if you can give me some info.. i could check it out.

truhlikfredy commented 4 years ago

@kwin I think I should be able to do a release for it

Hansvdsteen commented 4 years ago

@truhlikfredy if you are able/allowed to release it.. please do..

truhlikfredy commented 4 years ago

@Hansvdsteen I'm not allowed to, but was saying to @kwin if he would give me the rights I could.

kwin commented 4 years ago

@truhlikfredy I sent you an invite long time ago to your other user name @AntonKrug. I now resend the invite to your new user. You should probably disable the old user then!

truhlikfredy commented 4 years ago

I see, I keep switching between them so I missed as I was checking wrong account at the wrong time, I accepted it now, hope that's not too late (could you check if that's accepted?). I will do the 1.1.1 by hand, but I could update the github actions to do automatic release maybe when there is a tag on the master branch? Done it with travis on my own repositories and it works pretty well but the github action should be more stable anyway.

kwin commented 4 years ago

Both invitations are still pending: Screenshot 2020-02-26 at 12 18 35

Please go again to https://github.com/kwin/cppcheclipse/invitations to accept.

I am fine with automatically creating a release once a tag is there.

truhlikfredy commented 4 years ago

Hopefully now they are accepted, thank you very much, tomorrow I will look into the release and then later how to make it automated. I did the automated thing with travis, but not yet with github actions, so I will practice first on a separate repository and when it will be working do it on this repository

truhlikfredy commented 4 years ago

So I played with my jfrog account and can upload the release and zipped from your bintry.ant script, only things which doesn't get uploaded is the updates (the composite upload), which depends on getMajorMinorVersion which seems to depend on updates already existing. So my guess is that it might be ok with your repository on bintray. Would you be so kind and add me to the bintray's cppcheclipse organization? My jfrog handle is antonkrugms.

AntonKrug commented 4 years ago

Made a 1.1.1 release, hopefully I did not messed up something. Always so worried when working on somebody's else repositories/projects.

Hansvdsteen commented 4 years ago

@AntonKrug where can i get/update it from? so i could test/verify it.

When is use https://dl.bintray.com/cppcheclipse/p2/updates/ i see version 1.1.0.v20160724-1648. I expect versions 1.1.1... or something.. am i right?

kwin commented 4 years ago

@AntonKrug Thanks a lot for the efforts, unfortunately I only see version 1.1.0 at the bintray p2 update site as well:

Screenshot 2020-03-03 at 19 46 29
AntonKrug commented 4 years ago

I'm very sorry for the hassle. In the meantime adding the zip from here should work https://github.com/kwin/cppcheclipse/releases/download/1.1.1/com.googlecode.cppcheclipse.repository-1.1.1.zip

And for the update repository I did the:

mvn -Dtycho.mode=maven org.eclipse.tycho:tycho-versions-plugin:set-version -DnewVersion=1.1.1
mvn clean verify -Prelease-composite

I see it in the zip/release folders in the bintray (however without the timestamp postfix), and the composite (for the update folder) run (which I couldn't before because the getMajorMinorVersion was not able to fetch):

getMajorMinorVersion:

push-composite-to-bintray:
    [apply]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
    [apply]                                  Dload  Upload   Total   Spent    Left  Speed
    [apply] 
    [apply]   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0100   514    0     0  100   514      0    328  0:00:01  0:00:01 --:--:--   327
    [apply] {"message":"success"}100   535  100    21  100   514     12    311  0:00:01  0:00:01 --:--:--   324
    [apply]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
    [apply]                                  Dload  Upload   Total   Spent    Left  Speed
    [apply] 
    [apply]   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0100   514    0     0  100   514      0    344  0:00:01  0:00:01 --:--:--   344
    [apply] {"message":"success"}100   535  100    21  100   514     11    290  0:00:01  0:00:01 --:--:--   302

push-main-composite-to-bintray:
    [apply]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
    [apply]                                  Dload  Upload   Total   Spent    Left  Speed
    [apply] 
    [apply]   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0100   491    0     0  100   491      0    308  0:00:01  0:00:01 --:--:--   308
    [apply] {"message":"success"}100   512  100    21  100   491     11    278  0:00:01  0:00:01 --:--:--   289100   512  100    21  100   491     11    278  0:00:01  0:00:01 --:--:--   289
    [apply]   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
    [apply]                                  Dload  Upload   Total   Spent    Left  Speed
    [apply] 
    [apply]   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0  0   491    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
    [apply] {"message":"success"}100   512  100    21  100   491     12    283  0:00:01  0:00:01 --:--:--   295100   512  100    21  100   491     12    283  0:00:01  0:00:01 --:--:--   295
[INFO] Executed tasks
AntonKrug commented 4 years ago

With the child and main composites I was struggling the most, will have to check the getMajorMinorVersion javascript if it still works and I struggle with the timestamp as well. Not sure if some features of the maven changed over the time. However in the mean time I updated the XMLs by hand and now the update get recognized and it does install if you do not have 1.1.1 already installed 1 1 1

Hansvdsteen commented 4 years ago

@AntonKrug i was able to download 1.1.1 now! Thanks for the hard work!. Only thing which still shows 1.1.0 version is in the market place. Don't know how this exactly works. image

@kwin it would also be nice to update the News section of the cppcheclipse wiki space.

AntonKrug commented 4 years ago

I can update the wiki, at least some draft and let @kwin approve the final touches. But will have to look up how to do the marketplace. And still not happy that my release is missing timestamp.

kwin commented 4 years ago

I updated the marketplace entry. @AntonKrug feel free to send me your eclipse.org account, then I can make you editor of the marketplace entry as well.

truhlikfredy commented 4 years ago

My marketplace handle is akrug. Will be ok with you for me to update the Wiki as well? And I specified java8 for the travis build, so now it is again working, I would say the github actions you added is the future and will be the one with the least hassle to keep going, but shouldn't hurt to have 2 different system just as extra sanity check. What is your preference?

kwin commented 4 years ago

@truhlikfredy Please merge your different Github accounts (https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/merging-multiple-user-accounts) it is really confusing to use two different accounts. I added akrug as editor to the marketplace entry, you can now edit it at https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/merging-multiple-user-accounts.

Feel free to update the wiki as well (preferably via PR). Regarding CI I would also rely on GH Actions in the future. Maybe we can also set up some automated SNAPSHOT deployment to bintray.