search

kwindrem / SetupHelper

Helper functions to simplify writing setup scripts that modify VenusOs functionality. The package includes automatic reinstallation of the package after a VenusOs update.
153 stars 18 forks source link

Junk files in the release tar.gz file #39

Open infamy opened 1 year ago

infamy commented 1 year ago

You have a ton of ._ files in the release tar.gz. These are cache files. I would recommend moving the release process to something like github workflows/ci/cd to prevent this. (same thing is present in guimods)

kwindrem commented 1 year ago

This was true at one time but I just checked the current release for SetupHelper and GuiMods and see no ._ files. The only thing I found was one .DS_Store file which I'll remove on the next release.

I also checked the blind install archive and found nothing there.

If you have a specific example, please let me know and I'll work on removing them.

infamy commented 1 year ago

Iin the readme you link to 

venus-data.tgz is available here:
    https://github.com/kwindrem/SetupHelper/raw/main/venus-data.tgz

Inside that file, i see a ._rc and then each directory is littered full of ._folderorfilenamehere

kwindrem commented 1 year ago

Got it. Didn't realize you were talking about the blind install which is different than what gets into the repo.

I have a fix and will include it in the next release. Unless you disagree, I don't consider this a serious issue requiring a new version just for this.

infamy commented 1 year ago

Yeah, I don't think it causes any issues. Just extra files. if there a reason you don't build the blind release with github actions? (would just be an extra assset)

kwindrem commented 1 year ago

I don't know that much about GitHub. It might be possible although I go outside the root file for SetupHelper to generate the necessary code since rcS.local and the rc directory needs to end up in /data not inside /data/SetupHelper.