kwindrem / SetupHelper

Helper functions to simplify writing setup scripts that modify VenusOs functionality. The package includes automatic reinstallation of the package after a VenusOs update.
153 stars 18 forks source link

Remove package should also remove from filesystem? #54

Closed mr-manuel closed 10 months ago

mr-manuel commented 10 months ago

Should the "Remove package" button also delete the package from the filesystem or only remove it from the active packages?

If it should only remove it from the active packages I would at least ask, if the package should also be removed from the filesystem.

kwindrem commented 10 months ago

Remove package flags the package so it will not be automatically reinstalled. With this flag set, the package just sits in /data. If you want to completely remove it, you'll need an ssh connection or local terminal.

mr-manuel commented 10 months ago

I understood. Would it be an Idea to add an option to delete it also from the GUI? Since it disappears from the GUI the user probably also thinks, that it got deleted from the system.

kwindrem commented 10 months ago

When a package is removed, it moves from Active packages to Inactive packages. It never really disappears from the GUI but it isn't shown as an Active package any longer.

I wanted to avoid lots of interaction during the processes managed from the GUI using PackageManager. It really is not a substitute for ssh interaction, rather something unskilled users can wrap their head around.

What I was trying to avoid by not deleting the package from /data was a download again if the user wanted to add the package again. There are systems that don't have a robust internet connection.