kwindrem / SetupHelper

Helper functions to simplify writing setup scripts that modify VenusOs functionality. The package includes automatic reinstallation of the package after a VenusOs update.
153 stars 18 forks source link

Increased version number fields #66

Closed herrfrei closed 4 months ago

herrfrei commented 4 months ago

For one project I need more space for the version number (see https://github.com/henne49/dbus-opendtu/pull/122):

sh-version-number

This PR increases the fields from 80 to 90 pixel:

sh-pkg-edit sh-act-pkg

May be we need to adjust the labels (e.g. installed: -> inst:)?

kwindrem commented 4 months ago

SetupHelper requires version numbers in the Victron format: v1.2~3. Nothing else wlll work properly regardless of what is displayed. I convert the version string to a number with 3 digits per major, minor and prerelease fields so I can identify which version is the "newest" when comparing values. Using a date-based version number will break this logic and install and reinstall will either fail or behavior undefined.

henne49 commented 4 months ago

https://github.com/henne49/dbus-opendtu/releases/tag/1.0.0 changed to semantic versioning OK, if that is the case, we are also fine to move to semantic versioning for the this release.

kwindrem commented 4 months ago

I did some tests and 2023.12.29 ends up with a version number of 23012029 because there is no v at the beginning of the string. v2023.12.29 ends up with 2023012029. Both would compare properly as long as v and non-v strings didn't coexist.

The added space you gave to the version strings looks crowded/truncated and would be truncated if v was included. I am working on some layout changes to better accommodate wider version strings.

I'll make all the necessary changes and publish a new v5.x version in the next day or so. Stand by

henne49 commented 4 months ago

@kwindrem we changed the numbering in our project, so we should be good to go. v.1.0.0 is now the actual release

kwindrem commented 4 months ago

OK. I'll work the changes into v6.0 but won't roll them into v5.X