search

kwing25 / Women-Who-ve-Changed-Tech

Updates coming soon 2023... Women Tech Pioneers API & React App 👩🏻‍💻. List of amazing Female Tech & STEM Pioneers. Contributions to the list are welcome!
MIT License
7 stars 13 forks source link

Add Ellen Ochoa to techwomen.json - Hacktoberfest #23

Closed Jethet closed 3 years ago

Jethet commented 3 years ago

I noticed I forgot the image_width so I added 150 there. The id number is still 7 so that will probably cause a merge conflict but I am not entirely clear what id I should use now.

Update: General (misc updates, features, fixes, etc.)

I have checked my code and corrected any misspellings. I have performed a self-review of my own code.

netlify[bot] commented 3 years ago

✔️ Deploy Preview for women-who-changed-tech ready!

🔨 Explore the source changes: 90c26e433b5f15482b5cd04f3c3c7e22cd1bae25

🔍 Inspect the deploy log: https://app.netlify.com/sites/women-who-changed-tech/deploys/61686cd2ae077c0008ed8d01

😎 Browse the preview: https://deploy-preview-23--women-who-changed-tech.netlify.app

kwing25 commented 3 years ago

Thanks for contributing. PR #23 👍

Jethet commented 3 years ago

I am not sure what you mean with your remark "Please remember to do a pull next time if you make changes." Do you mean I need to pull from upstream? I do that before I start working on something new. In this case, I created a pull request for same changes but with more description. Should I do that differently? As you may have guessed, I do not work on other people's repos often so not everything is obvious to me.