search

kwk / docker-registry-frontend

Browse and modify your Docker registry in a browser.
https://registry.hub.docker.com/u/konradkleine/docker-registry-frontend/
MIT License
1.68k stars 616 forks source link

🐛Fix tag links navigating to home #191

Open bvanderlaan opened 6 years ago

bvanderlaan commented 6 years ago

Some of the tag links when clicked would take you to the default page (i.e. home view). This only happened on images which didn't have a user prefix (i.e. nginx vs. my/nginx).

This happened because the links were built expecting the prefix so the URL was //nginx but that was not routed properly so the user fell into the catch other otherwise handler which took them to the repositories view.

This change set fixes that by building the links with URLs that include the prefix if it exists or without the prefix if the image does not have a user prefix.

ChaotX commented 6 years ago

Maybe that is an other issue, but in the docker image reference definition tests there is an example for multiple subrepo path component names: https://github.com/docker/distribution/blob/master/reference/reference_test.go like "sub-dom1.foo.com/bar/baz/quux" These names containing more / separator characters may still broke the links.