kwoide / capstone-project

capstone-project-kwoide.vercel.app
MIT License
0 stars 0 forks source link

Create a form with a submit button #2

Open kwoide opened 2 years ago

kwoide commented 2 years ago

Value Proposition

As a user I want to add a single restaurant So that I can collect my restaurants

Description

Image

Acceptance Criteria

Tasks

Complexity

L

Gw3i commented 2 years ago

Hello Kolja!

Great User Story. I would change some things. First, upload a scribble without the navigation, just the form. Second, you should write the acceptance criteria accurately what should be shown, because "Two to three input fields..." sounds not precise. You should also not mention what should happen in the future implementation because it's not part of the user story. Lastly, I would write the tasks more precise, because that will help you in the implementation.

kwoide commented 2 years ago

Hey Vlady,

Thank you very much for this detailed feedback. I have now revised the points you raised and would be happy to receive further feedback.

RobertBReich commented 2 years ago

Hey Kolja, looks good.

kwoide commented 2 years ago

Hey Kolja, looks good.

Hello Robert,

thank you for the feedback.

JessicaLoers commented 2 years ago

Hi @kwoide 👋

I'm super duper mean 👿 and have additional comments 😁

Value Proposition please be more precise regarding the User's value and perspective of this feature

As a user I want to have a form - This should be more an activity So that I can enter various data - the User's desired value of this feature

Here are some examples: As a user I want to add/create my own/a single menu ... So that I can collect my menus / have a list my favorite menus ...

Acceptance Criteria

The input field is required - Actually this is not a AC from the user's perspective, the user doesn't care about the required fields

I would recommend that you write a separate user story for the local storage feature - you don't need this for now. Rather render you entry in a simple list below your form.

By the way - Please change your project board to public 😉

kwoide commented 2 years ago

Hello Jessica,

Thank you very much for the detailed feedback. I have now revised the user story and hope that it will be accepted.

j-eick commented 2 years ago

I like it. 👍🏼 A few details:

AC

"A heading should be visible at first glance"

➡️ Try not to use "could/should/would". Instead: A heading is visible at first glance

"The input fields are the name of the restaurant, type of food and culinary variety"

➡️ What's meant by "culinary variety"?

Tasks

"edit linting"

➡️ I would specify this a bit more, but you do you. :)

"Add form validation"

➡️ I would be more specific here. How do you want to validate... etc. But again... you do you.

kwoide commented 2 years ago

Hello Joschka,

Thank you very much for your detailed feedback. I have now updated the user story and changed the following points.

Description

➡️ I have updated the scribble and adapted it to the new circumstances.

AC

➡️ I have implemented the note with the headline

➡️ I have changed the input field Culinary Variety. Now you can choose the price level by dropdown.

Tasks

➡️ The task with the linting was rephrased

➡️ Form validation is moved to another user story

@j-eick

ahohnsen commented 2 years ago

Hey Kolja,

As Jessica already said, I think it would be good to be a bit more specific in your acceptance criteria:

What happens after the user submit the form? Where are your entries displayed?

Example: By clicking on the submit button the new menu is added to a list below the form. (It would be also nice to see this in the scribble).

What happens if the user submit the form without the required input fields? Is an error message displayed?

As Jessica mentions in her previous comment, it would be best if there is an indication that an input field is required (e.g. with a *). You should think about what happens if not all required input fields are filled. The user will need some kind of visual feedback, so that he/she knows what to do next. This scenario should be described in your acceptance criteria as well.

All the things which are visible in the scribble, you do not need to mention again in your acceptance criteria (e.g. there is a heading, a button etc.).

Gw3i commented 2 years ago

Hey Kolja, really good User Story! There are just two typos: In AC the last field -> The entered data will be saved in a simple list below the form In Tasks 3rd field, to keep it consistent -> Deal with react hook form