search

kwokieee / pe

0 stars 0 forks source link

Incorrect multiplicity in UI diagram for HelpWindow #7

Open kwokieee opened 2 years ago

kwokieee commented 2 years ago

Bug inherited from AB3: HelpWindow should have multiplicity 0 because it is created when MainWindow is created. It only gets shown or hidden, but it is not destroyed until the app shuts down.

image.png

nus-pe-bot commented 2 years ago

Team's Response

I don't understand. If HelpWindow is created when MainWindow is created, the multiplicity should be 1. If it is 0 we shouldn't put it there at all.

Items for the Tester to Verify

:question: Issue response

Team chose [response.IssueUnclear]

Reason for disagreement: In the constructor for MainWindow, a new instance of HelpWindow is also created. After MainWindow is created, the other parts such as CommandBox, ResultDisplay, StatusBarFooter, etc. are created via the MainWindow::fillInnerParts method in the UiManager::start method. So HelpWindow's multiplicity should be consistent with that of CommandBox, ResultDisplay, StatusBarFooter, which as you have mentioned, should be 1. If a 0 is included, it implies that MainWindow can exist without reference to a HelpWindow, which is not true since HelpWindow is created when MainWindow is created.