kwokyto / pe

0 stars 0 forks source link

Diagram Bugs #24

Open kwokyto opened 3 years ago

kwokyto commented 3 years ago

self calls have no activation bars Objects are not labelled correctly, :Parser should be used

image.png

nus-pe-bot commented 3 years ago

Team's Response

No response provided.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Diagram Bugs

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


self calls have no activation bars objects not properly labelled do the object lifecycles end?

image.png


[original: nus-cs2113-AY2021S2/pe-interim#175] [original labels: severity.High type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

self calls have activation bars objects properly labelled do the object lifecycles end? while the objects are not explicitly destroyed in java, they end when the program exits.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.IssueUnclear]

Reason for disagreement: 1. self calls do not have activation bars

when self calls are made, activation bars are needed. for example:

image.png

in this diagram, these two do not have activation bars

image.png

2.objects are not labelled correctly

these are objects, not classes, ":" should be in front of all the objects

image.png

unless those are classes, to which, the following format should be used

image.png


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.High]

Reason for disagreement: As a new team member, this would significantly affect my understanding of the code. this is not merely a cosmetic error