search

kwoodson / ansible-role-yedit

Ansible Role for Yaml editing
164 stars 62 forks source link

Please update to the openshift version, including the timestamp fix #27

Open wknapik opened 7 years ago

wknapik commented 7 years ago

Hi,

The version of yedit used in openshift has and additional feature (edits), but it also (re?)introduces a bug (invalid timestamps).

Could you update the version here to include the feature, but exclude the bug ?

Thanks.

PS. I couldn't find a way to make yedit just leave the timestamps alone.

luto commented 6 years ago

@kwoodson is this repository still maintained? :-/ if there are two places to get yedit, a sync once in a while would be nice.

kwoodson commented 6 years ago

@luto, apologies as I have been heads down working on a few items as well as taking a little PTO. I'll pull down the latest from openshift-ansible.

kwoodson commented 6 years ago

@wknapik, I have updated to the latest version.

Please explain or show an example of the timestamps you are referring to. I'll attempt to fix.

wknapik commented 6 years ago

Hi @kwoodson. It's been nearly 5 months, I don't have the testcase anymore. It came down to timestamps added/updated (?) by yedit being invalid. I assumed you'd recognize the problem, since you've already fixed it once. If you don't find it, I could try to recreate a testcase.

kwoodson commented 6 years ago

I'm in the process of attempting to move this to ansible core. If you can recreate I'll attempt to fix before we get it upstream. I remember fixing a strange datetime string in the very beginning of yedit. It had to do with parsing it incorrectly but I haven't seen that problem in a long time.