search

kworkflow / patch-hub

patch-hub is a TUI that streamlines the interaction of Linux developers with patches archived on lore.kernel.org
GNU General Public License v2.0
7 stars 6 forks source link

Panic if hit `ENTER` with no bookmarked patchsets #12

Closed davidbtadokoro closed 2 months ago

davidbtadokoro commented 3 months ago

Description:

In the "Bookmarked Patchsets" screen, the program panics if there are no bookmarked patchsets, and the user hits ENTER as if it were to choose a bookmarked patchset.

How to reproduce:

  1. Go to the "Bookmarked Patchsets" screen (you must have at least one bookmarked patchset for this)
  2. Unbookmark every patchset to end up with an empty list (see screenshot 1 below)
  3. Hit the ENTER key
  4. Notice that the program panics (see screenshot 2 below)

Expected behavior:

This panic shouldn't happen. Actually, it would be better to notify the user that there are no bookmarked patchsets and revert to the "Mailing List Selection" screen (or just revert to it).

Screenshots

Screenshot 1:

2024-07-26-013712_1723x937_scrot

Screenshot 2:

2024-07-26-013756_855x553_scrot

Setup:

th-duvanel commented 2 months ago

I'm currently working on this.