search

kworkflow / patch-hub

patch-hub is a TUI that streamlines the interaction of Linux developers with patches archived on lore.kernel.org
GNU General Public License v2.0
7 stars 6 forks source link

Cargo.toml linting #40

Closed OJarrisonn closed 1 month ago

OJarrisonn commented 1 month ago

This PR is a continuation of what were done in #38

Here i'm reinforcing the rules in the format_and_lint workflow in Cargo.toml. This feature is really helpful since every rule will now be enforced at compile time rather than at "pull request time". Also for those who use a LSP/IDE the rules will be enforced at code editing time.

Just by adding this section to the Cargo.toml a lot of overhead with PRs being refused just by formatting reasons will be avoided

davidbtadokoro commented 1 month ago

Hi @OJarrisonn, and thank you so much for this PR.

Can't we also take the opportunity to add the aliases to account for the options to cargo clippy (the ones before --) like mentioned in #39 ? I ask this because not automating these options would result in either the developers not having the same linting routines as the CI and the pre-commit or the developers having to type these extra options.

davidbtadokoro commented 1 month ago

Hi @OJarrisonn, and thank you for the update with the addition of the alias. Change merged into the unstable branch :+1: