search

kwpugh / easy_emerald_forge

Provides emerald and ruby tools and such [Forge]
4 stars 7 forks source link

[1.19.2] Bow issue with shield 2.0 #17

Closed someonedeepintheinternet closed 1 year ago

someonedeepintheinternet commented 1 year ago

So the issue got solved at first. not trying to be a dck, but the issue is still there but when you have a arrow in the inventory. Without the arrow it works fine. Sorry mate

kwpugh commented 1 year ago

I just noticed this in testing. This may not be fixable with the forge event though.

What problem is this causing in your game play?

kwpugh commented 1 year ago

I think the only way to solve this is to require that the off hand is empty when using the bow in main hand with zoom

I'm not sure that is a better situation

someonedeepintheinternet commented 1 year ago

Well that sucks but its not that dramatic in my opinion. I can live with that. I thought you coded it like a usual minecraft bow.

kwpugh commented 1 year ago

Minecraft vanilla code does not expose the built in zoom, so I wrote a custom zoom with the side benefit being to set the zoom factor for the bow in the mod's config

kwpugh commented 1 year ago

I think I would rather give them the zoom while blocking with a shield rather than leaving them scratching their head as to why now zoom on the bow, when there is something in their off hand.

someonedeepintheinternet commented 1 year ago

did you try to look into other mods that include a bow? Maybe they solved the issue already(kind of). Can't help ya much with coding, never learned it in any way.

kwpugh commented 1 year ago

I had, but the level of their code complexity was beyond me.

To be totally honest, my forge mods are mostly in maintenance mode. My primary efforts going forward will be on Fabric and Quilt. 1.19.2 or 1.19.3 or likely the last version I will be supporting them.

That said, I'm not willing to expend a lot of effort chasing this down. My fabric bows use similar code but the Fabric API doesn't seem to have this quirk.

someonedeepintheinternet commented 1 year ago

alright, as i said, i can live with the small bug. Its your mod, your rules and doings. The mod itself is good enough. Shall i close the issue or let it open?