kwpugh / mining_Dimensions

Creative Commons Zero v1.0 Universal
1 stars 8 forks source link

Open void in the mining dimesion #2

Closed LMSparrow closed 2 years ago

LMSparrow commented 2 years ago

I'm using the 1.18 generation datapack for 1.17 while using this mod and I come across a pocket of void where the rest of the cave would be. 2021-07-21_16 25 01

kwpugh commented 2 years ago

Yep, 1.17 mods are designed for 1.17 not 1.18.

YuRaNnNzZZ commented 2 years ago

https://feedback.minecraft.net/hc/en-us/articles/4402614709389-Caves-Cliffs-Prototype-Data-Pack-for-Minecraft-Java-Edition This is clearly a 1.17 datapack, intended to run in 1.17.

kwpugh commented 2 years ago

it changes world height which is not currently supported as a general standard. I will be supporting the new world height when Mojang releases it with 1.18.

YuRaNnNzZZ commented 2 years ago

it's okay, a simple datapack with edited world heights seem to fix that

kwpugh commented 2 years ago

very good. Mods cannot access the new world height, because it is not part of the Fabric API.

Enjoy.

LMSparrow commented 2 years ago

You could just force a layer of bedrock at y 0 like in a superflat world

kwpugh commented 2 years ago

I'm fine waiting until I see how Mojang implements things in 1.18