kwpugh / mob_catcher_fabric

Creative Commons Zero v1.0 Universal
2 stars 7 forks source link

Suggestion: add entity type blacklist tag for this mod #22

Closed TelepathicGrunt closed 4 months ago

TelepathicGrunt commented 1 year ago

Hello, I am making some new entities for my mod and was looking into various mod's abilities to capture my entities. Most are using a tag blacklist so I am able to add my entity to those tags by adding the tag to my jar file. Mob Catcher seems to not have a blacklist tag which means I can't prevent the item from capturing my new uncapturable entities by default. Would you be willing to add a tag for this?

kwpugh commented 1 year ago

When I get back to updating mods, I will do that

kwpugh commented 4 months ago

I'm finally getting around to these, sorry for the delay.

At this point, should I just be checking that the entity in question is NOT in CAPTURING_NOT_SUPPORTED ?

kwpugh commented 4 months ago

ok, I think I figured out how to use the new tag

kwpugh commented 4 months ago

I will also add the check to my Staff of Ensnarements in Gobber.

kwpugh commented 4 months ago

Which version of Minecraft did you add the new mob in question? I fixed this for 1.20.6 and I'm wondering how far back I may need to back port.

TelepathicGrunt commented 4 months ago

My Bumblezone mod with the entity in question is on 1.20.1 and 1.20.4 as my main supporting versions for a while