SearchableSelect - Githubissues

soyef-bit commented 3 years ago

I think if the typing is not case agnostic, but can’t be sure. I think it should be case agnostic.
Searching Samsung with capital S doesn’t give that option. Same goes for all others. They all start with capitals, but don’t return on typing with capital first letter.
Does pressing enter select the most likeliest option, or do you have to use mouse. There is no indication that typing “l, g, enter” selects LG.
Having no placeholder defaults to blackberry, what is the logic behind it when Apple is alphabetically first?
Having a placeholder makes it behave like an item on the list.
Adding a placeholder doesn’t appear on the component unless you first attempt to search.
Check if dd_class is working. couldnt get it to work with is-primary

ekhaled commented 3 years ago

soyef-bit commented 3 years ago

searchableselect

[x] Why is blackberry pre-selected on the second input?
[x] dd_class has been removed.
[x] typing something wrong doesn't make the clear all button show up.
[x] pressing the clear all button doesn't keep the input in focus. ideally i should be able to clear all and start typing again.

multiselect

[ ] newer selected items appear on the start of the displayed selections. Ideally it should be the last item on the displayed selection. Eg. Selecting Nokia, followed by LG, will put LG at the beginning.
[x] typing something wrong doesn't make the clear all button show up.
[x] pressing the clear all button doesn't keep the input in focus. ideally i should be able to clear all and start typing again.
[x] disabling the inputs keeps the colour theme, which is okay on default, but on other colours it doesn’t visually look disabled, especially when an item is already selected in the input. If a change is made such that colours are greyed on disable, then could carry that over to searchable select too.
[x] hover cursor when input is disabled

other than that all seems fine

kws3media / ui