kws3media / ui

MIT License
7 stars 2 forks source link

Datepicker new issues #96

Closed soyef-bit closed 3 years ago

soyef-bit commented 3 years ago
sunnypol92 commented 3 years ago

@ekhaled changed min & max type to string, it effective now, And it should be a usage issue in storybook, not making any issues on real life

sunnypol92 commented 3 years ago

@soyef-bit you can pull master and can check min & max dates

soyef-bit commented 3 years ago

@sunnypol92 Checked.

I am able to work with enable_dates. Noticed that if 2 dates are put into the array, it enables these 2 dates only. Not all the dates in between. Is that by design?

I am still unable to work with disable_dates. Putting more than one date in the array results in disabling only the last date in the array Actually this working the same way as enable_dates, i.e not a range of dates, but the selected dates only get disabled.

Bug

Did not check the min_date max_date functionality as they are storybook issues as mentioned above.

Now that min_date max_date are string only, shall i change the docs to reflect that. Not doing it since it is the master branch.

soyef-bit commented 3 years ago

verified and spoke to @sunnypol92 . everything is working fine and the issue in the last comment is to do with storybook.

may be the doc Enables a range of dates and disables all others is misleading and should be something along the lines of Enables a list of dates and disables all others, and the same with disable_dates

ekhaled commented 3 years ago

There is documentation at the bottom of the page on various usage of enable_dates and disable_dates.

You can send a specific date, or a range of dates using from and to parameters. You can also send a function to dynamically work out whether to disable a specifc date or not.

Please close after verification of this

soyef-bit commented 3 years ago

Done