kwsch / NHSE

Animal Crossing: New Horizons save editor
https://berichan.github.io/GetNHSE/
GNU General Public License v3.0
1.01k stars 260 forks source link

Color river shores / waterfalls with shores / cliffs differently #251

Open Corgano opened 4 years ago

Corgano commented 4 years ago

Currently, All river / water tiles (and cliffs!) appear the same in the editor, making it VERY difficult to edit rivers without remembering the ID's of each corner, plus their orientation. This also applies to waterfalls!

I don't know if the field item editor (more a map editor at this point) supports graphics for the tiles, but it would REALLY help if there was some differentiation.

image In this example I colored some of the tiles to make it MUCH more apparent what kind of river / waterfall they are. It is immiedietly obvious what each tile is. Before all the river tiles were just straight blue! The same can be done for cliffs - they behave very similarly.

kwsch commented 4 years ago

Would need information on what each tile type/rotation/variant needs to look like when drawn; there's a LOT of combinations that I don't want to document (myself).

Corgano commented 4 years ago

Tell me what format you want the list in and I'll document it. I've struggled with this for long enough that I remember a quarter of them

kwsch commented 4 years ago

List of terrain models

Would need a spreadsheet of sorts listing:

model | variant | rotation | appearance

a model can have multiple variants, and each of those permutations can be rotated. You can probably get away with describing just model-variant permutations, since rotations are likely a 90degree turn (same for all).

Corgano commented 4 years ago

what i found is for river / cliff sections, all the variant does is give it a slight texture change to make it look less samey. You could easily randomize variant for these tiles with no functional difference, but a very slight graphical variation.

There should be a checkbox for random variant added to the field item editor, it;d actually be quite handy

I'll work on making a sheet up today and tomorrow

Possum80 commented 4 years ago

Agree with the above. Select and copy/change to the wrong tile, and that part of map becomes glitchy in game, with see through areas or areas you cannot change or interact with in game.

Corgano commented 4 years ago

test save - tile types.zip I made a save file that has one of every tile, in all rotations. I can upload somewhere if you like. Working on the list now

Corgano commented 4 years ago

https://docs.google.com/spreadsheets/d/12LOYvdpuKxqYc9cuDfMc3PawgVv8mFcOVn6x449kU9s/edit?usp=sharing Still in progress

Corgano commented 4 years ago

Done river and cliffs. waterfalls are going to be a pain to try and describe because they deal with water, cliffs, and land. figured out how you're going to draw them yet?

Corgano commented 4 years ago

Edit: All tiles done! some descriptions are missing, but all ground tiles have been documented! Tiles.zip https://docs.google.com/spreadsheets/d/12LOYvdpuKxqYc9cuDfMc3PawgVv8mFcOVn6x449kU9s

Corgano commented 4 years ago

Any update on this? I'd work on implementing it myself but I've never used C# before.

Possum80 commented 4 years ago

Open issues are essentially a 'to do' list. Some can be done easily, and others will take time. Just give the developers time.

Possum80 commented 4 years ago

Corgano, the list you posted is missing data for inclines

Corgano commented 4 years ago

Right i hadn't gotten around to those yet. Inclines are very simple, all the same length and only 90 degrees, i can catalog them in a bit

On Sun, Jun 7, 2020, 7:24 AM Possum80 notifications@github.com wrote:

Corgano, the list you posted is missing data for inclines

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kwsch/NHSE/issues/251#issuecomment-640218587, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGSARPD6NTZGUX42GQGRSLRVOIKDANCNFSM4NJFMCOQ .

Corgano commented 3 years ago

If you mean the editor in general, this is really NOT the place to ask. Checking say the releases page or main page for the project will tell you more.

If you mean coloring the shores / inclines better, this is a request thread. Something that was never in an update can't "still work" because it never worked.

On Tue, Jan 26, 2021 at 2:42 PM Anonymous notifications@github.com wrote:

Does this still work in the latest update?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kwsch/NHSE/issues/251#issuecomment-767846373, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGSAROUEUBEYHLUUPLRFN3S34ZNHANCNFSM4NJFMCOQ .

Elfykins commented 1 year ago

I know this is a necro, but I am sad that this was never implemented, you did amazing work getting them all done, and it would have been absolutely awesome to have them in the editor!