search

kwsch / NHSE

Animal Crossing: New Horizons save editor
https://berichan.github.io/GetNHSE/
GNU General Public License v3.0
1.01k stars 260 forks source link

Imported designs that are placed don't respect path matching #641

Closed lottehime closed 6 months ago

lottehime commented 6 months ago

Bug introduced by overwriting the values starting at 0x70 with 4 bytes of 0x00 to reset some of the ownership data.

This causes imported patterns that are placed on the ground to not respect the shape of the ground/path underneath them when transparency is involved (demonstrated in the original user comment below).

This is unintended behavior and can be reproduced by using a dump, save or DA dump and then exporting and re-importing the patterns from the player in the save, as well as individually importing island info from a dump into a save (like in the original comment).

This bug fix seems to have introduced another bug，When I copied other people's islands through the new version of NHSE, it seemed that there were some issues with the land, but the old version of NHSE performed normally

before after

[DA-1608-5112-4385].zip

Originally posted by @hunshikan in https://github.com/kwsch/NHSE/issues/634#issuecomment-1858696572

lottehime commented 6 months ago

Issue and fix identified. Will implement the fix soon when time permits.

lottehime commented 6 months ago

Should be fixed in https://github.com/kwsch/NHSE/commit/57dda232cee5989f0b10ccd410d5cd00735be833.