search

kwsch / PKHeX

Pokémon Save File Editor
https://projectpokemon.org/pkhex/
Other
3.63k stars 681 forks source link

Legality errors in latest commits #1377

Closed PrometheusG closed 7 years ago

PrometheusG commented 7 years ago

Hi,

I tested generations 3,4,5,6,7 and come up with various legality errors with PKHeX Build 3617

Gen 4: HeartGold

Pokewalker Pokemon Some of the pokewalker pokemon dont have the Pokewalker PID: Pikachu:Encounter type PID mismatch + PID:None(instead of Pokewalker Venomoth:Same Poliwag:Same Shelder:Same Onix:same Horsea:same Carvanha:same duskull, dusclops:same ++ I will throw inside the .zip a metang from Pokewalker that is shows as legit.I don't know with the others lost the PID, I obtained them myself

HeartGold Pokemon.zip

Thanks

-kwsch edit: removed content associated with other (recently fixed) issues -PrometheusG edit 2: tested with PKHeX Build 3622, only pokewalker error remains as said in the comment of the commit 2a4aa0b, thank you!

sora10pls commented 7 years ago

D/P static encounter bugs were already fixed by my recent PR.

xXAquaNightXx commented 7 years ago

There seems to be a legality error with the relearn moves from GEN 6 and 7 pokemon , it looks like its not reading the first relearn slot

err1

And if you fill in the second slot its legal

err2

Same with user's pokemon above moving

err3

PrometheusG commented 7 years ago

Hi, Just a small update testing PKHeX build 3624:

Gen 4- HeartGold- PID spiky ear pichu

Spiky ear pichu shows PID type:Pokewalker instead of none, like the previous build was showing.If I reroll the PID it shows as none but it will make the pichu illegal I think I am also adding a beldum and a metagross(leveled up and evolved) from winner's path Pokewalker route, I forgot to put them in the older .zip file. they are legit in this build (3624) but were legit in the PKHeX build 3617 too. It doesn't matter I know because it is fixed, but you can keep them if you need to check anything else.

Gen 7 - Moon - In-game trades - wc6 JPN greninja

I also noticed that gen 6 greninja JPN event is fixed in AS but the error remains in Moon(Invalid: Form Count is out of range. Expected <= 0, got 0.)

Some in-game trades in moon throw an error too, a memories tab error.The memories with OT show:"The Pokémon seems to have a good memory, but it doesn’t seem to be able to remember..." If I change the memory to this (I take alola golem as an example,it is provided inside the .zip file as well as all in-game trades): "Veler met Sill at... a cave. Sill threw a Poké Ball at it, and they started to travel together. The Pokémon remembers that its feelings were indescribable." it is legit again

Also that alola golem sometimes when I click on it it throws an excpetion error, the same as issue 1378 so I will not expand myself on that error

Thank you

gen 4 - gen 7 files.zip