kwsch / PKHeX

Pokémon Save File Editor
https://projectpokemon.org/pkhex/
Other
3.7k stars 692 forks source link

Shortcut removed? #1618

Closed Arch9SK7 closed 6 years ago

Arch9SK7 commented 6 years ago

So despite it still being apart of the shortcuts in the tab explaining all of pkhex' shortcuts. the one for giving suggested movesets for relearn moves (at least for sun and moon save files doesnt work at all, haven't tried on any other saves). i have clicked in and around every inch of the box to get it to give me suggested relearn moves for my pokemon but it just will not show anything. I have tried shift clicking and control clicking and again nothing. Was this removed, bugged out? did i miss something in a previous build? the build i have is as of 11 commits ago now as i am writing this. (it is a simple diggersby).

sora10pls commented 6 years ago

You literally just click anywhere in the Relearn Moves groupbox, it was never removed or changed

Arch9SK7 commented 6 years ago

Boi i did and it didn't work and i just now realized that it is only when you import a set from showdown that it doesn't work. (if you change one of the moves then try again it works again) but still a bug nonetheless.

sora10pls commented 6 years ago

I'm unable to replicate your issue regardless.

Arch9SK7 commented 6 years ago

Enter this set then

OG Bugz (Diggersby) (M) @ Master Ball
Ability: Cheek Pouch
Shiny: Yes IVs: 31s EVs: 252 HP / 252 Atk / 4 SpD
Adamant Nature

sora10pls commented 6 years ago

IVs: 31s

Importing the set works fine for me, and automatically enters Relearn Moves.

image

OG Bugz (Diggersby) (M) @ Master Ball
Ability: Cheek Pouch
Shiny: Yes
EVs: 252 HP / 252 Atk / 4 SpD
Adamant Nature
- Fire Punch
- Gunk Shot
- Iron Head
- Ice Punch
Arch9SK7 commented 6 years ago

that wasn't what i typed ive you leave in the iv part i put in and the (invalid lines window shows up) you can no longer use relearn moves till you change a move on it.

sora10pls commented 6 years ago

The reason I excluded what I entered at the top of my comment is because Pokemon Showdown never exports that line, ever. It'll only display IV values if they're below 31.

Arch9SK7 commented 6 years ago

well that is where the bug comes in

sora10pls commented 6 years ago

Pokemon Showdown never exports that line, ever.

There is no bug with PKHeX, the problem lies with your invalid set.

Arch9SK7 commented 6 years ago

omg i know an invalid line that bugs out a function in the program

sora10pls commented 6 years ago

If the user inputs an invalid set compared to what's expected, obviously, an invalid output will occur. PKHeX shouldn't have to baby the user for a line that Pokemon Showdown will never generate.

Please @kwsch, if you think it's necessary, lock this issue. The bug mentioned in the title doesn't exist.

kwsch commented 6 years ago

If you click the box and get no message, it's because the current moves match whatever is suggested. If the current moves are invalid and you get no message, it's because there's something else that needs to be fixed.