search

kwsch / PKHeX

Pokémon Save File Editor
https://projectpokemon.org/pkhex/
Other
3.63k stars 681 forks source link

Legality checks #1700

Closed PrometheusG closed 6 years ago

PrometheusG commented 6 years ago

Hi,

Having compiled the latest build of PKHeX, I have found some issues that even exist on the latest official release. I haven't touched the pokemon that I list here. I have caught them in the wild or bred them. This issue is somehow similar to issue 1693(gen 3 legality error) but with some extra error warnings, except rng frame.

Emerald Save File: I have found emerald.zip

1)A Skarmory that says: "Analysis not available for this pokemon" 2) Miltank 3) Mawile 4) Volbeat that all of them say: "fishy=Unable to match encounter conditions to a possible rng frame" (issue 1693)

But opening rng reported and inputing the origin seed of the pokemon I have found the frame.

Pearl Save File: Pearl.zip

1) Wormadam : Form Count is out of range. Expected <= -1, got 1.=== If I drag and drop it to another save file(platinum,white,alpha sapphire) it is made legit again. 2) Deoxys from emerald save file, after pal park to pearl it says : Form Count is out of range, Expected <= -1, got 3. Drag and dropping it this time makes it legal but changes the form to normal and If I try to make it speed form again it throws the same error. Opening it in platinum save file it is shown as legit in it's speed form.

Platinum Save File : Platinum.zip

Sharpedo Whiscash Both with the rng frame "fishy" error (issue 1693)

HeartGold Save File : HeartGold.zip

Butterfree(National Park) Scyther(National Park) Dragonite(from LeafGreen-Safari) Nincada(National Park) All of them with the error : Can't have ball for encounter type.

I hope these zip files prove useful. Thank you for everything

kwsch commented 6 years ago

Thanks :)

For the 'fishy' messages for RNG frame, it's working as intended for now until it is fixed separately. If the RNG frames can't be verified with current implementation/knowledge, it is flagged for needing manual verification.

The origin seed value listed by PKHeX is for Method 1/2/4 encounter methods; for wild encounters, the actual encounter methid is to be H/J/K (gen3/dppt/hgss respectively) -- the seed listed is still not for these...