search

kwsch / PKHeX

Pokémon Save File Editor
https://projectpokemon.org/pkhex/
Other
3.72k stars 700 forks source link

Pokemon XD Shiny Skip Pokemon flagged as Illegal #2832

Closed Sephirona closed 4 years ago

Sephirona commented 4 years ago

Hi! I finished RNGing a refresh Salamence in XD recently using the Shiny Skip method for an Adamant 31/31/31/25/31/31 spread, but after I finished the game and traded it over to my Emerald file through the trade center under Phenac it was marked as illegal due to a PID mismatch by PkHex. It was successfully RNGed with the following frame sequence for the party Pokemon, 1 salamence plan

I marked the rerolled PID in red.

2 salamence pid hit

The first Nature Lock mon is a Docile Female, the second Pokemon is a Manectric that has its PID rerolled because of the shiny lock (TSV 2446) to two frames extra over the usual 7 frames it would take to generate the Shadow Pokemon, and then from the new Manectric PID the Salamence was generated 7 frames later with the Shiny Skip PID of 53505668.

I think that you may have already addressed a similar issue in ticket #2751 earlier this year, so if this is related and you already know about it, then sorry! It's just slightly different to the shiny skip reroll sequence outlined in that other ticket so I figured I'd open this one too.

Sephirona commented 4 years ago

Just wanted to add on to this, Anubis also got back to me with your latest commit as of the moment of this post and it's still coming up as a PID mismatch.

kwsch commented 4 years ago

Fixed by above linked commit (forgot to include as commit message).

Thanks for reporting!