kwsch / PKHeX

Pokémon Save File Editor
https://projectpokemon.org/pkhex/
Other
3.67k stars 689 forks source link

Galar - Location textvar limitations for memories 42 and 70. #3249

Closed Skadiv closed 3 years ago

Skadiv commented 3 years ago

Describe the problem Memory 42 (reading a sign) and memory 70 (sitting on a bench) are limited by the availability of signs and benches throughout Galar. Location textvars outside of the conceivable range aren't marked as illegal as of now.

To Reproduce Example: Neither memory 42 or memory 70 are possible with location textvar 2: at home. There might be sofas and single chairs but your character isn't allowed to sit on those. None of the objects in there count as a sign either.

Expected behavior Flag as illegal anything outside of the following legal memory - location textvar combinations:

Screenshots Only interactions with this type of text box trigger memory 42. Slowpoke enjoys sitting at the station.

Additional context Went on a nice little stroll through Galar, looking for benches I could sit on and signs that triggered memory 42. Recorded my findings in an excel.

Skadiv commented 3 years ago

Adding onto limitations for memories... Memory 51 ({0} was excited when {1} won prizes like {2} through Loto-ID. {4} that {3}.) seems fairly limited in its contents. The only items that can be obtained through the Loto-ID are MooMoo Milk, PP Up, PP Max, Rare Candy and Masterball.

Hence the only legal item textvars for memory 51 are 1, 33, 50, 51 and 53.