search

kwsch / PKHeX

Pokémon Save File Editor
https://projectpokemon.org/pkhex/
Other
3.71k stars 698 forks source link

GSC .dat legalities #3266

Closed CanoeHope closed 3 years ago

CanoeHope commented 3 years ago

Describe the problem A clear and concise description of what the bug is. This is not to ask why fabricated data does not pass the legality check.

For GSC, any Pokemon that evolves by direct trade is flagged as an outsider for some reason. This only affects the .dat extensions of the save, and works fine on .sav for some reason.

To Reproduce Please provide a PKM file or adequate information so that we may quickly replicate the parsing behavior on our end.

Check out a legal Graveler, Machoke, Haunter, and Kadabra on the .dat extension of a GSC save file.

Expected behavior A clear and concise description of what you expected to happen.

Legal on .dat extension, too.

Screenshots If applicable, add screenshots to help explain your problem.

Here's how it looks on .dat: error error2

Here's .sav: error1 error3

Additional context Add any other context about the problem here.

N/A

kwsch commented 3 years ago

You're ignoring the existence of Stadium 2 (not-Virtual-Console) which can move stuff between trainer save files without triggering the trade animation ;)