search

kwsch / PKHeX

Pokémon Save File Editor
https://projectpokemon.org/pkhex/
Other
3.71k stars 698 forks source link

Loading modifies notOT Memory Feeling #3267

Closed MarkRDowd closed 3 years ago

MarkRDowd commented 3 years ago

Describe the bug Loading PK8 file randomizes the Feeling field in notOT Memories (byte address 0xCB). This causes the Pokemon to be exported with a different checksum even if nothing else was changed, which can cause difficulties keeping things organized if the exportation causes unnecessary duplicates to appear.

To Reproduce Load the same PK8 file into two different box slots and compare their notOT Memories. I just tried with the same Cottonee file and one says "it got lighthearted" and the second one says "it was happy".

Expected behavior Loading the same file should give the same notOT data. Just loading a file should not automatically modify ANYTHING.

kwsch commented 3 years ago

Not a bug.

The program adapts the data to the currently loaded save file to preserve legality; if you're loading the pk8 to a different save file / blank save file, then this is the expected behavior.

There is a setting to turn this behavior off.

MarkRDowd commented 3 years ago

Which setting turns it off? It's not very obvious which one affects this behavior.

Lusamine commented 3 years ago

image For Set to box updating the PKM.

MarkRDowd commented 3 years ago

Thank you