search

kwsch / PKHeX

Pokémon Save File Editor
https://projectpokemon.org/pkhex/
Other
3.74k stars 702 forks source link

EMR: Battle frontier symbols get set to 0 #3279

Closed BartTerpstra1 closed 3 years ago

BartTerpstra1 commented 3 years ago

when using misc edits on a save file, battle frontier symbols get set from their current values to [none]. it can read correctly if they have been attained, but saving misc edits sets them to 1 less than you loaded them as.

To Reproduce Steps to reproduce the behavior:

  1. open a save with battle frontier gold or silver symbols
  2. go to misc>battle frontier> save
  3. close misc editor
  4. open misc editor
  5. you're symbols are now all silver or [none] respectively

Expected behavior i expect the symbols to be saved as what is shown when i view the battle frontier tab, whether i have edited them or not.

Additional context i have also had issues with getting working ferry tickets, but this is probably unrelated.

BartTerpstra1 commented 3 years ago

(the implication of this bug is that you can still assign Silver by saving Gold, but you can't assign Gold)

kwsch commented 3 years ago

https://github.com/kwsch/PKHeX/blob/338bc562bb9ed90c49752acf52381ab3f5da6a18/PKHeX.WinForms/Subforms/Save%20Editors/Gen3/SAV_Misc3.cs#L380-L386 https://github.com/kwsch/PKHeX/blob/338bc562bb9ed90c49752acf52381ab3f5da6a18/PKHeX.WinForms/Subforms/Save%20Editors/Gen3/SAV_Misc3.cs#L392-L402