search

kwsch / PKHeX

Pokémon Save File Editor
https://projectpokemon.org/pkhex/
Other
3.74k stars 702 forks source link

Issue with Magnezone legality #3314

Closed NinFanBoyFTW closed 2 years ago

NinFanBoyFTW commented 2 years ago

Hi, I just looked at my BDSP saves for a legality check and PKHeX is saying that my Magnezone which I legit caught as a magnemite and then evolved is illegal for knowing zap cannon and "unable to match an encounter". Ill attach the file below. Thanks 462 - Magnezone - 2316659C51CA.zip

kwsch commented 2 years ago

Similar issue as Feebas having multiple evolution types to Milotic, with the more restricted one (trades) being checked first.

Will have to rearrange the evolution data for that...

NinFanBoyFTW commented 2 years ago

Hey thanks for fixing that issue. I just checked again with the latest commit and I have one more like this, being this milotic I legit traded and evolved as feebas 350 - Milotic - 57AFA827A961.zip

ReignOfComputer commented 2 years ago

You evolved the Milotic with Prism Scale trade, can the Prism Scale be found in BDSP?

NinFanBoyFTW commented 2 years ago

I may be mistaken then. I thought that it was available in the underground but that may be a rumor

Lusamine commented 2 years ago

Heart Scale exists there, not Prism Scale. Mon is appropriately illegal if evolved with an illegal item that doesn't exist.

NinFanBoyFTW commented 2 years ago

I just realized I was getting mixed up with the available trade items like the deep sea scale and the dragon scale. Is there maybe a way to make a feature when adding items to games to add another button next to the "Give All" button that says something like "Give All Legal Items "excluding non obtainable items? this seems like it would also be useful in other games like sword and shield where if you were to have a black list of all unobtainable items, you wouldn't have a bag full of those dynamax crystals that are not even available and other items like that. Maybe just a thought?

Edit: This suggestion would also go for all other sections like pokeballs where this problem has been apparent for a while with most games having the gen 2 apricot balls or cherish, park safari balls etc available in items but illegal for that specific game. When an item is theoretically available like the code cards for those balls with these games then they could be taken off of the black list