search

kwsch / PKHeX

Pokémon Save File Editor
https://projectpokemon.org/pkhex/
Other
3.74k stars 702 forks source link

Opening the mystery gift database freezes the program #3315

Closed Kermalis closed 2 years ago

Kermalis commented 2 years ago

Describe the bug Title. Tried it in a SWSH file and a BDSP file and happens either way. This is in the latest commit, possibly due to the splitting of the subprojects

Kermalis commented 2 years ago

Yep, splitting the subprojects means you missed one of the extension methods. There's a silent StackOverflowException being thrown because the extension method is calling itself. Easy to miss when changing namespace usings

image

It should be calling MysteryGiftSpriteUtil.Sprite(this MysteryGift gift) in PKHeX.Drawing.Misc